https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.68.2 2023-01-21T17:44:20+00:00 2023-01-21T17:44:20+00:00 bors bors@rust-lang.org 2023-01-21T17:44:20+00:00 urn:sha1:52372f9c71d8ade4cb815524f179119656f0aa2e Remap paths in UI tests by default If you think this needs further discussions / something RFC-like, please let me know the best forum for that. This PR runs UI tests with a remapped "src base" directory by default. Why? Because some UI tests currently depend on the length of the absolute path to the `src/test/ui` directory. Remapping makes the tests independent of the absolute path. The path to the source file (which is absolute on CI) is part of the type name of closures. `rustc` diagnostic output depends on the length of type names (long type names are truncated). So a long absolute path leads to long closure type names, which leads to truncation and changed diagnostics. (I initially tried just disabling type name truncation, but that made some error messages stupid long (thousands of characters, IIRC)). Additional changes: * All boolean `compiletest` directives now support explicit `no-` versions to disable them. * Adapt existing tests when necessary: * Disable remapping for individual tests that fail with it enabled (when there's no obvious alternative fix). * For tests that already check something remapping related switch to the new option unless we gain something significant by keeping the manual remap. Passed Windows CI in https://github.com/rust-lang/rust/actions/runs/3933100590 2023-01-20T15:28:40+00:00 bors bors@rust-lang.org 2023-01-20T15:28:40+00:00 urn:sha1:a6269dad38e6ede0013ba3688099544833933c63 Rollup of 6 pull requests Successful merges: - #106699 ([drop tracking] Visit break expressions ) - #106738 (Fix known-bug annotations) - #106891 (Tweak "borrow closure argument" suggestion) - #106928 (add raw identifier for keyword in suggestion) - #107065 (Clippy: Make sure to include in beta: Move `unchecked_duration_subtraction` to pedantic) - #107068 (autoderive Subdiagnostic for AddtoExternBlockSuggestion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup 2023-01-20T04:52:28+00:00 bors bors@rust-lang.org 2023-01-20T04:52:28+00:00 urn:sha1:56ee85274e5a3a4dda92f3bf73d1664c74ff9c15 Remove some `ref` patterns from the compiler Previous PR: https://github.com/rust-lang/rust/pull/105368 r? `@Nilstrieb` 2023-01-19T20:20:58+00:00 Michael Goulet michael@errs.io 2023-01-11T19:44:49+00:00 urn:sha1:a3d5be6631f9d7cef7aeabb5fb9694aacc37f969 2023-01-18T11:09:15+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2023-01-18T11:09:15+00:00 urn:sha1:f46f9231a8058bcbfc2c1442f86c072f5bd92ddc 2023-01-17T11:23:29+00:00 Maybe Waffle waffle.lapkin@gmail.com 2023-01-17T11:02:46+00:00 urn:sha1:65d1e8d9b556095dc50dc357e1ec4899afc3e975 2023-01-16T18:33:25+00:00 Tim Neumann timnn@google.com 2023-01-06T11:49:07+00:00 urn:sha1:cd1d0bc20cd2c18ec844f6447396dadf90b762e9 2023-01-16T18:09:39+00:00 Tim Neumann timnn@google.com 2023-01-06T11:48:03+00:00 urn:sha1:10fe7bfc7394b32471f1bad199fd9f8300cd80c2 2023-01-16T18:09:39+00:00 Tim Neumann timnn@google.com 2023-01-06T11:40:45+00:00 urn:sha1:d79207273842c9fd414b9060f74c411d9610b28d 2023-01-11T09:32:13+00:00 Albert Larsan 74931857+albertlarsan68@users.noreply.github.com 2023-01-05T08:45:44+00:00 urn:sha1:40ba0e84d53f605ccf01836e9c2d27892728ae81