https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.89.0 2025-05-29T09:00:36+00:00 2025-05-29T09:00:36+00:00 Michael Goulet michael@errs.io 2025-05-23T14:58:24+00:00 urn:sha1:73382e44174d79510a515488bafc1afa88920811 2025-04-07T07:19:38+00:00 Jieyou Xu jieyouxu@outlook.com 2025-04-07T07:16:45+00:00 urn:sha1:5f7fa4f97587092a851bfb23f8620ed0919c96c3 2025-01-09T16:56:50+00:00 Rémy Rakic remy.rakic+github@gmail.com 2025-01-09T16:56:50+00:00 urn:sha1:958a7722d172ca3864f1abee9f55bcd020b2ef09 in particular to get the new benchmark error handling 2024-08-08T16:24:39+00:00 Shina 53410646+s7tya@users.noreply.github.com 2024-08-08T16:24:39+00:00 urn:sha1:85ec34182415f8ba475cc157f405c785db05e4be 2024-06-12T09:45:52+00:00 Jakub Beránek berykubik@gmail.com 2024-06-12T09:45:52+00:00 urn:sha1:3bbd480f07dcc3a8b9516232d041eada63b10a81 To integrate https://github.com/rust-lang/rustc-perf/pull/1926. 2024-06-03T15:38:23+00:00 Weihang Lo me@weihanglo.tw 2024-05-31T13:30:41+00:00 urn:sha1:e9c4eb3cd31cd373867369e78b2695f1f5a3c299 This is needed for fixing the missing license issue. See https://github.com/rust-lang/rust/pull/125465. 2024-05-24T15:25:46+00:00 Weihang Lo me@weihanglo.tw 2024-05-24T15:25:46+00:00 urn:sha1:99c9b0775fba00de9a114be430506f30d65a34de 2024-05-20T14:56:49+00:00 Bernardo Meurer Costa bemeurer@amazon.com 2024-05-14T18:47:15+00:00 urn:sha1:e287044149edf039ffd584557b4bf05507a9f213 Currently, it's very challenging to perform a sandboxed `opt-dist` bootstrap because the tool requires `rustc-perf` to be present, but there is no proper management/tracking of it. Instead, a specific commit is hardcoded where it is needed, and a non-checksummed zip is fetched ad-hoc. This happens in two places: `src/ci/docker/host-x86_64/dist-x86_64-linux/Dockerfile`: ```dockerfile ENV PERF_COMMIT 4f313add609f43e928e98132358e8426ed3969ae RUN curl -LS -o perf.zip https://ci-mirrors.rust-lang.org/rustc/rustc-perf-$PERF_COMMIT.zip && \ unzip perf.zip && \ mv rustc-perf-$PERF_COMMIT rustc-perf && \ rm perf.zip ``` `src/tools/opt-dist/src/main.rs` ```rust // FIXME: add some mechanism for synchronization of this commit SHA with // Linux (which builds rustc-perf in a Dockerfile) // rustc-perf version from 2023-10-22 const PERF_COMMIT: &str = "4f313add609f43e928e98132358e8426ed3969ae"; let url = format!("https://ci-mirrors.rust-lang.org/rustc/rustc-perf-{PERF_COMMIT}.zip"); let client = reqwest::blocking::Client::builder() .timeout(Duration::from_secs(60 * 2)) .connect_timeout(Duration::from_secs(60 * 2)) .build()?; let response = retry_action( || Ok(client.get(&url).send()?.error_for_status()?.bytes()?.to_vec()), "Download rustc-perf archive", 5, )?; ``` This causes a few issues: 1. Maintainers need to be careful to bump PERF_COMMIT in both places every time 2. In order to run `opt-dist` in a sandbox, you need to provide your own `rustc-perf` (https://github.com/rust-lang/rust/pull/125125), but to figure out which commit to provide you need to grep the Dockerfile 3. Even if you manage to provide the correct `rustc-perf`, its dependencies are not included in the `vendor/` dir created during `dist`, so it will fail to build from the published source tarballs 4. It is hard to provide any level of automation around updating the `rustc-perf` in use, leading to staleness Fundamentally, this means `rustc-src` tarballs no longer contain everything you need to bootstrap Rust, and packagers hoping to leverage `opt-dist` need to go out of their way to keep track of this "hidden" dependency on `rustc-perf`. This change adds rustc-perf as a git submodule, pinned to the current `PERF_COMMIT` 4f313add609f43e928e98132358e8426ed3969ae. Subsequent commits ensure the submodule is initialized when necessary, and make use of it in `opt-dist`.