https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=beta 2024-02-25T23:45:45+00:00 2024-02-25T23:45:45+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-25T22:24:03+00:00 urn:sha1:bf7d1b54e8a3195a0f52516d48659d9f1270436d This call was added to `parse_crate_mod` in #121487, to fix a case where a stashed diagnostic wasn't emitted. But there is another path where a stashed diagnostic might fail to be emitted if there's a parse error, if the `build` call in `parse_crate_inner` fails before `parse_crate_mod` is reached. So this commit moves the `emit_stashed_diagnostic` call outwards, from `parse_crate_mod` to `format_project`, just after the `Parser::parse_crate` call. This should be far out enough to catch any parsing errors. Fixes #121517. 2024-02-23T05:09:51+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-23T02:20:33+00:00 urn:sha1:41da3d6f2fa3ef3eb49c576d82c6879d4b336ef8 Commit 72b172b in #121206 changed things so that `emit_stashed_diagnostics` is only called from `run_compiler`. But rustfmt doesn't use `run_compiler`, so it needs to call `emit_stashed_diagnostics` itself to avoid an abort in `DiagCtxtInner::drop` when stashed diagnostics occur. Fixes #121450. 2021-05-15T02:53:36+00:00 Caleb Cartwright caleb.cartwright@outlook.com 2021-05-15T02:53:36+00:00 urn:sha1:b2d45c0d4b2d44789000ebec6d702cc27db19782 git-subtree-dir: src/tools/rustfmt git-subtree-mainline: e659b6de9170c055b6f2d16e2679b22d67297b13 git-subtree-split: 7872306edf2e11a69aaffb9434088fd66b46a863