https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.83.0 2024-10-11T13:11:13+00:00 2024-10-11T13:11:13+00:00 bors bors@rust-lang.org 2024-10-11T13:11:13+00:00 urn:sha1:f4966590d8edd5f493a1aab04016b94a75494329 Retire the `unnamed_fields` feature for now `#![feature(unnamed_fields)]` was implemented in part in #115131 and #115367, however work on that feature has (afaict) stalled and in the mean time there have been some concerns raised (e.g.[^1][^2]) about whether `unnamed_fields` is worthwhile to have in the language, especially in its current desugaring. Because it represents a compiler implementation burden including a new kind of anonymous ADT and additional complication to field selection, and is quite prone to bugs today, I'm choosing to remove the feature. However, since I'm not one to really write a bunch of words, I'm specifically *not* going to de-RFC this feature. This PR essentially *rolls back* the state of this feature to "RFC accepted but not yet implemented"; however if anyone wants to formally unapprove the RFC from the t-lang side, then please be my guest. I'm just not totally willing to summarize the various language-facing reasons for why this feature is or is not worthwhile, since I'm coming from the compiler side mostly. Fixes #117942 Fixes #121161 Fixes #121263 Fixes #121299 Fixes #121722 Fixes #121799 Fixes #126969 Fixes #131041 Tracking: * https://github.com/rust-lang/rust/issues/49804 [^1]: https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Unnamed.20struct.2Funion.20fields [^2]: https://github.com/rust-lang/rust/issues/49804#issuecomment-1972619108 2024-10-07T11:30:33+00:00 bors bors@rust-lang.org 2024-10-07T11:30:33+00:00 urn:sha1:7caad6925314911eefe54b040d4bc5be940e8f92 Rollup of 4 pull requests Successful merges: - #131331 (Revert "warn_old_master_branch" check) - #131344 (Avoid `&Lrc<T>` in various places) - #131346 (Restrict `ignore-mode-*` directives) - #131353 (Add documentation for `runtest::check_rustdoc_test_option` method) r? `@ghost` `@rustbot` modify labels: rollup 2024-10-07T10:23:54+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-10-07T10:23:54+00:00 urn:sha1:df61a0b1b2e60a22807df704c11e5763e480e3c9 Avoid `&Lrc<T>` in various places Seeing `&Lrc<T>` is a bit suspicious, and `&T` or `Lrc<T>` is often better. r? `@oli-obk` 2024-10-07T08:59:55+00:00 bors bors@rust-lang.org 2024-10-07T08:59:55+00:00 urn:sha1:0b16baa570d26224612ea27f76d68e4c6ca135cc Rename `NestedMetaItem` to `MetaItemInner` Fixes #131087 r? `@nnethercote` 2024-10-07T06:22:03+00:00 codemountains 4kz12zz@gmail.com 2024-10-06T23:49:47+00:00 urn:sha1:fc64ff7ec2aad5261365c0cfc033f65140828eb2 2024-10-07T02:56:29+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-10-07T00:03:52+00:00 urn:sha1:731469fee50133528c1904a07da73e739db6f6c4 It's simpler and more concise. 2024-10-06T17:00:09+00:00 Folkert de Vries folkert@folkertdev.nl 2024-09-05T17:45:40+00:00 urn:sha1:5fc60d1e52ea12f53d2c8d22fee94592860739ad - fix for divergence - fix error message - fix another cranelift test - fix some cranelift things - don't set the NORETURN option for naked asm - fix use of naked_asm! in doc comment - fix use of naked_asm! in run-make test - use `span_bug` in unreachable branch 2024-10-06T16:12:25+00:00 Folkert de Vries folkert@folkertdev.nl 2024-09-05T11:45:26+00:00 urn:sha1:562ec5a6fb469a360b72aa8ba0ce149598cc7975 also disallow the `noreturn` option, and infer `naked_asm!` as `!` 2024-10-06T16:12:25+00:00 Folkert folkert@folkertdev.nl 2024-08-04T14:42:37+00:00 urn:sha1:aa5bbf05f424ae7bfb2bd859141c7e8553120d87 2024-10-06T14:28:30+00:00 codemountains 4kz12zz@gmail.com 2024-10-04T12:59:04+00:00 urn:sha1:6dfc4a0473ed0901b9c0d09f5189c41f3882d5fc