rust/tests/mir-opt/building/custom/consts.rs, branch try-perfhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try-perf2024-06-03T03:24:44+00:00Reformat `mir!` macro invocations to use braces.2024-06-03T03:24:44+00:00Nicholas Nethercoten.nethercote@gmail.com2024-06-03T00:19:57+00:00urn:sha1:ac242996366cd0d1ec48ff76638320969c65bed3
The `mir!` macro has multiple parts:
- An optional return type annotation.
- A sequence of zero or more local declarations.
- A mandatory starting anonymous basic block, which is brace-delimited.
- A sequence of zero of more additional named basic blocks.
Some `mir!` invocations use braces with a "block" style, like so:
```
mir! {
let _unit: ();
{
let non_copy = S(42);
let ptr = std::ptr::addr_of_mut!(non_copy);
// Inside `callee`, the first argument and `*ptr` are basically
// aliasing places!
Call(_unit = callee(Move(*ptr), ptr), ReturnTo(after_call), UnwindContinue())
}
after_call = {
Return()
}
}
```
Some invocations use parens with a "block" style, like so:
```
mir!(
let x: [i32; 2];
let one: i32;
{
x = [42, 43];
one = 1;
x = [one, 2];
RET = Move(x);
Return()
}
)
```
And some invocations uses parens with a "tighter" style, like so:
```
mir!({
SetDiscriminant(*b, 0);
Return()
})
```
This last style is generally used for cases where just the mandatory
starting basic block is present. Its braces are placed next to the
parens.
This commit changes all `mir!` invocations to use braces with a "block"
style. Why?
- Consistency is good.
- The contents of the invocation is a block of code, so it's odd to use
parens. They are more normally used for function-like macros.
- Most importantly, the next commit will enable rustfmt for
`tests/mir-opt/`. rustfmt is more aggressive about formatting macros
that use parens than macros that use braces. Without this commit's
changes, rustfmt would break a couple of `mir!` macro invocations that
use braces within `tests/mir-opt` by inserting an extraneous comma.
E.g.:
```
mir!(type RET = (i32, bool);, { // extraneous comma after ';'
RET.0 = 1;
RET.1 = true;
Return()
})
```
Switching those `mir!` invocations to use braces avoids that problem,
resulting in this, which is nicer to read as well as being valid
syntax:
```
mir! {
type RET = (i32, bool);
{
RET.0 = 1;
RET.1 = true;
Return()
}
}
```
Fix tests and bless2024-04-24T12:12:33+00:00Gary Guogary@garyguo.net2024-04-19T15:54:41+00:00urn:sha1:cfee72aa24725ab8310c9d8c7085368489de567eAllow to run filecheck in mir-opt tests.2023-10-19T15:51:52+00:00Camille GILLOTgillot.camille@gmail.com2023-10-16T17:36:39+00:00urn:sha1:4ff03cd1a49dbf08f24c7054d4fd478e87c3a4deFix mir-opt tests for big-endian platforms2023-01-12T17:05:30+00:00Ulrich Weigandulrich.weigand@de.ibm.com2022-12-22T15:33:12+00:00urn:sha1:6885733c41844ac0ea24b965e91616a16a631697
The test cases src/test/mir-opt/building/custom/consts.rs and
src/test/mir-opt/const_prop/mutable_variable_no_prop.rs are
currently failing on big-endian platforms as the binary encoding
of some constants is hard-coded in the MIR test files. Fix this
by choosing constant values that have the same encoding on big-
and little-endian platforms.
The test case src/test/mir-opt/issues/issue_75439.rs is failing
as well, but since the purpose of the test is to validate handling
of big-endian integer encodings on a little-endian platform, it does
not make much sense to run it on big-endian platforms in the first
place - we can just ignore it there.
Fixed part of https://github.com/rust-lang/rust/issues/105383.
Move /src/test to /tests2023-01-11T09:32:08+00:00Albert Larsan74931857+albertlarsan68@users.noreply.github.com2023-01-05T08:13:28+00:00urn:sha1:cf2dff2b1e3fa55fa5415d524200070d0d7aacfe