https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.87.0 2025-02-11T13:29:58+00:00 2025-02-11T13:29:58+00:00 Guillaume Gomez guillaume1.gomez@gmail.com 2025-02-07T16:50:14+00:00 urn:sha1:673fd23dff47bf72953d1408b1cfbd45f6ef859b 2024-10-23T23:15:23+00:00 Michael Howell michael@notriddle.com 2024-10-23T23:15:23+00:00 urn:sha1:a53655a023cee5dee1873bd3dfc805d7c460fbeb 2024-09-29T17:02:06+00:00 Michael Howell michael@notriddle.com 2024-09-29T17:02:06+00:00 urn:sha1:c27b54ac4ad88bc2aa07260cebec31e886a3c6ad 2024-09-24T03:49:11+00:00 Michael Goulet michael@errs.io 2024-09-24T03:49:11+00:00 urn:sha1:0a0ea28f26b37d44a27380713f98b5d9c97f309b rustdoc: redesign toolbar and disclosure widgets Fixes #77899 Fixes #90310 ## Preview | before | after | ------ | ----- |  |  |  |  |  |  |  |  |  |  | N/A |  |  |  |  |  https://notriddle.com/rustdoc-html-demo-12/toolbar-v2/std/index.html ## Description This adds labels to the icons and moves them away from the search box. These changes are made together, because they work together, but are based on several complaints: * The [+/-] thing are a Reddit-ism. They don't look like buttons, but look like syntax <https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/More.20visual.20difference.20for.20the.20.2B.2F-.20.20Icons>, <https://github.com/rust-lang/rust/issues/59851> (some of these are laundry lists with more suggestions, but they all mention [+/-] looking wrong) * The settings, help, and summary buttons are also too hard to recognize <https://lwn.net/Articles/987070/>, <https://github.com/rust-lang/rust/issues/90310>, <https://github.com/rust-lang/rust/issues/14475#issuecomment-274241997>, <https://internals.rust-lang.org/t/improve-rustdoc-design/12758> ("Not all functionality is self-explanatory, for example the [+] button in the top right corner, the theme picker or the settings button.") The toggle-all and toggle-individual buttons both need done at once, since we want them to look like they go together. This changes them from both being [+/-] to both being arrows. CC <https://github.com/rust-lang/rust/pull/113074#issuecomment-1677469680> and ``@jsha`` regarding the use of triangles for disclosure, which is what everyone wanted, but was pending a good toggle-all button. This PR adds a toggle-all button that should work. Settings and Help are also migrated, so that the whole group can benefit from being described using actual words. The breadcrumbs also get redesigned, so that they use less space, by shrinking the parent module path parts. This is done at the same time as the toolbar redesign because it's, effectively, moving space from the toolbar to the breadcrumbs. This is aimed at avoiding any line wrapping at desktop sizes. ## Prior art This style of toolbar, with explicit labels on the buttons, used to be more popular. It's not very common in web browsers nowadays, and for truly universal icons like :arrow_left: I can understand why, but words are great when icons fail.  2024-09-20T14:02:32+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2024-09-20T13:34:45+00:00 urn:sha1:660210c4af12ebcf9e76f897c2542339fe7ce110 2024-09-11T00:56:17+00:00 Michael Howell michael@notriddle.com 2024-09-03T21:25:40+00:00 urn:sha1:df307d00852cdd0a23dfe7e981f3ad6aee7eda8a 2024-09-11T00:56:06+00:00 Michael Howell michael@notriddle.com 2024-09-03T02:42:28+00:00 urn:sha1:5b1b2e97e36c4966b9c6c30d5679f6da76503fc7 This tweaks it to use less space for the breadcrumbs. 2024-09-11T00:56:05+00:00 Michael Howell michael@notriddle.com 2024-08-25T06:11:30+00:00 urn:sha1:d05323c7b4ebeaeaffe3ea8e0d02a8b01db67ddd This adds labels to the icons and moves them away from the search box. These changes are made together, because they work together, but are based on several complaints: * The [+/-] thing are a Reddit-ism. They don't look like buttons, but look like syntax <https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/More.20visual.20difference.20for.20the.20.2B.2F-.20.20Icons>, <https://github.com/rust-lang/rust/issues/59851> (some of these are laundry lists with more suggestions, but they all mention [+/-] looking wrong) * The settings, help, and summary buttons are also too hard to recognize <https://lwn.net/Articles/987070/>, <https://github.com/rust-lang/rust/issues/90310>, <https://github.com/rust-lang/rust/issues/14475#issuecomment-274241997>, <https://internals.rust-lang.org/t/improve-rustdoc-design/12758> ("Not all functionality is self-explanatory, for example the [+] button in the top right corner, the theme picker or the settings button.") The toggle-all and toggle-individual buttons both need done at once, since we want them to look like they go together. This changes them from both being [+/-] to both being arrows. Settings and Help are also migrated, so that the whole group can benefit from being described using actual words. Additionally, the Help button is only shown on SERPs, not all the time. This is done for two major reasons: * Most of what's in there is search-related. The things that aren't are keyboard commands, and the search box tells you about that anyway. Pressing <kbd>?</kbd> will temporarily show the button and its popover. * I'm trading it off by showing the help button, even on mobile. It's useful since you can use the search engine suggestions there. * The three buttons were causing line wrapping on too many desktop layouts. 2024-09-02T23:04:59+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2024-09-02T22:42:13+00:00 urn:sha1:55bc638a1d3e5c19fcec3462bb8357dea6f7f56c 2024-09-02T13:59:00+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2024-09-02T13:59:00+00:00 urn:sha1:e3af6dc23915f027b9de0721aae86f794a053627