https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=master 2024-12-17T02:56:10+00:00 2024-12-17T02:56:10+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T02:57:46+00:00 urn:sha1:121e87bf1490f0258bdb354eb8c4e891ebb7e7e7 `CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com> 2023-11-24T18:15:52+00:00 Nilstrieb 48135649+Nilstrieb@users.noreply.github.com 2023-11-21T16:44:51+00:00 urn:sha1:87a354b15d3fd3579610325b6a3061d28088b63f Co-authored-by: Adrian <adrian.iosdev@gmail.com> 2023-01-11T09:32:08+00:00 Albert Larsan 74931857+albertlarsan68@users.noreply.github.com 2023-01-05T08:13:28+00:00 urn:sha1:cf2dff2b1e3fa55fa5415d524200070d0d7aacfe