https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=master 2024-07-24T21:03:27+00:00 2024-07-24T21:03:27+00:00 Esteban Küber esteban@kuber.com.ar 2024-07-23T19:43:46+00:00 urn:sha1:850faea030db4b260719d99be4191d7803efdb35 We don't want to have questions in the diagnostic output. Instead, we use wording that communicates uncertainty, like "might": ``` error[E0432]: unresolved import `spam` --> $DIR/import-from-missing-star-3.rs:2:9 | LL | use spam::*; | ^^^^ you might be missing crate `spam` | = help: consider adding `extern crate spam` to use the `spam` crate ``` 2024-04-21T07:45:03+00:00 Xiretza xiretza@xiretza.xyz 2024-04-20T12:52:05+00:00 urn:sha1:c88bb6c011a034a8b29d2a61734de0d36a02a1e9 2024-03-05T01:14:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-29T03:53:44+00:00 urn:sha1:60ea6e2831952110b81fd76190ee66a2f094febd 2024-03-05T01:14:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-29T00:58:51+00:00 urn:sha1:18715c98c67235274843974c928a70e84946398b 2024-02-22T16:04:04+00:00 许杰友 Jieyou Xu (Joe) jieyouxu@outlook.com 2024-02-22T12:10:29+00:00 urn:sha1:6e48b96692d63a79a14563f27fe5185f122434f8 2023-11-25T21:38:40+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-11-21T22:53:07+00:00 urn:sha1:57cd5e6551ffcd071aa0496f9b8c0ed28dca7ffe Currently we always do this: ``` use rustc_fluent_macro::fluent_messages; ... fluent_messages! { "./example.ftl" } ``` But there is no need, we can just do this everywhere: ``` rustc_fluent_macro::fluent_messages! { "./example.ftl" } ``` which is shorter. 2023-07-26T08:42:40+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-07-26T08:42:40+00:00 urn:sha1:ad8303739f9f62827e2192eb991b951809369a54 2023-06-01T14:45:18+00:00 Deadbeef ent3rm4n@gmail.com 2023-05-17T10:30:14+00:00 urn:sha1:4f83717cf768adb0b0dfe23b8eecf2b259eec354 2023-04-18T18:56:22+00:00 Nilstrieb 48135649+Nilstrieb@users.noreply.github.com 2023-04-16T12:33:00+00:00 urn:sha1:b5d3d970fa64c25eecfbd8ebbae601a2c6cb2cb3 Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`). 2023-04-18T03:40:31+00:00 jyn github@jyn.dev 2023-04-18T01:00:36+00:00 urn:sha1:d6af60266eed9a19ee550278cdfe1d2857763286 Nils had an excellent idea the other day: the same way that rustdoc is able to load `rustc_driver` from the sysroot, ui-fulldeps tests should also be able to load it from the sysroot. That allows us to run fulldeps tests with stage1, without having to fully rebuild the compiler twice. It does unfortunately have the downside that we're running the tests on the *bootstrap* compiler, not the in-tree sources, but since most of the fulldeps tests are for the *API* of the compiler, that seems ok. I think it's possible to extend this to `run-make-fulldeps`, but I've run out of energy for tonight. - Move `plugin` tests into a subdirectory. Plugins are loaded at runtime with `dlopen` and so require the ABI of the running compile to match the ABI of the compiler linked with `rustc_driver`. As a result they can't be supported in stage 1 and have to use `// ignore-stage1`. - Remove `ignore-stage1` from most non-plugin tests - Ignore diagnostic tests in stage 1. Even though this requires a stage 2 build to load rustc_driver, it's primarily testing the error message that the *running* compiler emits when the diagnostic struct is malformed. - Pass `-Zforce-unstable-if-unmarked` in stage1, not just stage2. That allows running `hash-stable-is-unstable` in stage1, since it now suggests adding `rustc_private` to enable loading the crates. - Add libLLVM.so to the stage0 target sysroot, to allow fulldeps tests that act as custom drivers to load it at runtime. - Pass `--sysroot stage0-sysroot` in compiletest so that we use the correct version of std.