https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.87.0 2025-03-26T12:30:12+00:00 2025-03-26T12:30:12+00:00 Vadim Petrochenkov vadim.petrochenkov@gmail.com 2025-03-22T18:42:34+00:00 urn:sha1:92d802eda669d69481b99139523008df1c456ba8 2025-02-27T21:42:06+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-04-18T06:22:02+00:00 urn:sha1:7ea59e053bed52249ba8f42cbdbc7301312197e3 Note: there was an existing code path involving `Interpolated` in `MetaItem::from_tokens` that was dead. This commit transfers that to the new form, but puts an `unreachable!` call inside it. 2025-02-21T00:41:17+00:00 Michael Goulet michael@errs.io 2025-02-20T23:05:38+00:00 urn:sha1:0a7ab1d6df4a2cfac819b0bada85b9142ac8ba26 2025-02-10T20:21:39+00:00 Esteban Küber esteban@kuber.com.ar 2024-07-09T22:30:26+00:00 urn:sha1:f0845adb0c1b7a7fa1bef73e749b2d7e1d7f374d ``` error[E0610]: `{integer}` is a primitive type and therefore doesn't have fields --> $DIR/attempted-access-non-fatal.rs:7:15 | LL | let _ = 2.l; | ^ | help: if intended to be a floating point literal, consider adding a `0` after the period and a `f64` suffix | LL - let _ = 2.l; LL + let _ = 2.0f64; | ``` 2025-01-07T15:04:14+00:00 Mara Bos m-ou.se@m-ou.se 2024-10-31T10:39:45+00:00 urn:sha1:585c9765a203df7cc7b497d848aae4ba979fcb39 2024-11-03T21:55:52+00:00 dianne diannes.gm@gmail.com 2024-11-02T23:10:24+00:00 urn:sha1:d7d6238b235fe65caedefd346c2a7107eb0a2656 This is consistent with all other diagnostics I could find containing features and enables the use of `DiagSymbolList` for generalizing diagnostics for unstable library features to multiple features. 2024-08-23T04:40:08+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-08-20T07:47:53+00:00 urn:sha1:1ae521e9d57ba3a67b1007204da2836d8b19b4a2 This example triggers an assertion failure: ``` fn f() -> u32 { #[cfg_eval] #[cfg(not(FALSE))] 0 } ``` The sequence of events: - `configure_annotatable` calls `parse_expr_force_collect`, which calls `collect_tokens`. - Within that, we end up in `parse_expr_dot_or_call`, which again calls `collect_tokens`. - The return value of the `f` call is the expression `0`. - This inner call collects tokens for `0` (parser range 10..11) and creates a replacement covering `#[cfg(not(FALSE))] 0` (parser range 0..11). - We return to the outer `collect_tokens` call. The return value of the `f` call is *again* the expression `0`, again with the range 10..11, but the replacement from earlier covers the range 0..11. The code mistakenly assumes that any attributes from an inner `collect_tokens` call fit entirely within the body of the result of an outer `collect_tokens` call. So it adjusts the replacement parser range 0..11 to a node range by subtracting 10, resulting in -10..1. This is an invalid range and triggers an assertion failure. It's tricky to follow, but basically things get complicated when an AST node is returned from an inner `collect_tokens` call and then returned again from an outer `collect_token` node without being wrapped in any kind of additional layer. This commit changes `collect_tokens` to return early in some extra cases, avoiding the construction of lazy tokens. In the example above, the outer `collect_tokens` returns earlier because the `0` token already has tokens and `self.capture_state.capturing` is `Capturing::No`. This early return avoids the creation of the invalid range and the assertion failure. Fixes #129166. Note: these invalid ranges have been happening for a long time. #128725 looks like it's at fault only because it introduced the assertion that catches the invalid ranges. 2024-07-12T03:02:57+00:00 Esteban Küber esteban@kuber.com.ar 2024-07-06T03:07:46+00:00 urn:sha1:692bc344d55cf9d86c60b06c92a70684d013c89f Go over all structured parser suggestions and make them verbose style. When suggesting to add or remove delimiters, turn them into multiple suggestion parts. 2024-05-10T07:16:27+00:00 León Orell Valerian Liehr me@fmease.dev 2024-05-05T23:25:49+00:00 urn:sha1:0ad3c5da72469c848e321ddee207f9a5dfbf9876 2024-05-04T09:30:38+00:00 Urgau urgau@numericable.fr 2024-04-06T22:33:37+00:00 urn:sha1:d4e26fbb5301b465a037c4d2ff54024ebd7f73d8