rust/tests/ui/consts/const-eval/ub-int-array.stderr, branch autohttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=auto2025-09-03T13:24:49+00:00don't uppercase error messages2025-09-03T13:24:49+00:00Sasha Pourcelotsasha.pourcelot@protonmail.com2025-09-01T14:47:55+00:00urn:sha1:5c4b61b4b4b13e408b28ecc91f4f517e78e6b5e7
a more general version of https://github.com/rust-lang/rust/pull/146080.
after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines :sweat_smile:. this pr lowercases the first letter of all the error messages in the codebase.
(i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_)
i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry.
in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
Use the informative error as the main const eval error message2025-06-02T15:37:15+00:00Oli Scherergithub333195615777966@oli-obk.de2025-05-28T10:29:08+00:00urn:sha1:b331b8b96d86a6433df957a3cc49ed51f3656135compiletest: Make diagnostic kind mandatory on line annotations2025-04-30T07:44:24+00:00Vadim Petrochenkovvadim.petrochenkov@gmail.com2025-04-05T16:19:56+00:00urn:sha1:20faf8532b5ddeb636ba3078344b0cad058c8f8aFix ub-int-array test for big-endian platforms2023-08-24T10:49:53+00:00Ulrich Weigandulrich.weigand@de.ibm.com2023-08-24T10:44:42+00:00urn:sha1:2063067a8159d9527f98630af7d79397a358fcd3
As of commit 7767cbb3b0b332fd0a46e347ea7f68f20109d768,
the tests/ui/consts/const-eval/ub-int-array.rs test is
failing on big-endian platforms (in particular s390x),
as the stderr output contains a hex dump that depends
on endianness.
Since this point intentionally verifies the hex dump to
check the uninitialized byte markers, I think we should
not simply standardize away the hex dump as is done with
some of the other tests in this directory.
However, most of the test is already endian-independent.
The only exception is one line of hex dump, which can
also be made endian-independent by choosing appropriate
constants in the source code.
Since the 32bit and 64bit stderr outputs were already
(and remain) identical, I've merged them and removed
the stderr-per-bitwidth marker.
Fixes (again) https://github.com/rust-lang/rust/issues/105383.