https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=auto 2023-12-12T04:54:25+00:00 2023-12-12T04:54:25+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-11T22:55:50+00:00 urn:sha1:226edf64fa58e591d8abc6afef5e38c15c181698 Attribute values must be literals. The error you get when that doesn't hold is pretty bad, e.g.: ``` unexpected expression: 1 + 1 ``` You also get the same error if the attribute value is a literal, but an invalid literal, e.g.: ``` unexpected expression: "foo"suffix ``` This commit does two things. - Changes the error message to "attribute value must be a literal", which gives a better idea of what the problem is and how to fix it. It also no longer prints the invalid expression, because the carets below highlight it anyway. - Separates the "not a literal" case from the "invalid literal" case. Which means invalid literals now get the specific error at the literal level, rather than at the attribute level. 2023-01-11T09:32:08+00:00 Albert Larsan 74931857+albertlarsan68@users.noreply.github.com 2023-01-05T08:13:28+00:00 urn:sha1:cf2dff2b1e3fa55fa5415d524200070d0d7aacfe