rust/tests/ui/functional-struct-update/functional-struct-update-noncopyable.stderr, branch 1.85.1https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.85.12024-04-12T20:57:07+00:00review comments2024-04-12T20:57:07+00:00Esteban Küberesteban@kuber.com.ar2024-04-12T20:57:07+00:00urn:sha1:4c7213c888174612250f77c29d929c16b331ade5
Added comments and reworded messages
Account for move error in the spread operator on struct literals2024-04-11T16:41:42+00:00Esteban Küberesteban@kuber.com.ar2024-03-16T18:19:17+00:00urn:sha1:d578ac9e476a376246320db1d934972601c5b0f5
We attempt to suggest an appropriate clone for move errors on expressions
like `S { ..s }` where a field isn't `Copy`. If we can't suggest, we still don't
emit the incorrect suggestion of `S { ..s }.clone()`.
```
error[E0509]: cannot move out of type `S<K>`, which implements the `Drop` trait
--> $DIR/borrowck-struct-update-with-dtor.rs:28:19
|
LL | let _s2 = S { a: 2, ..s0 };
| ^^^^^^^^^^^^^^^^
| |
| cannot move out of here
| move occurs because `s0.c` has type `K`, which does not implement the `Copy` trait
|
help: clone the value from the field instead of using the spread operator syntax
|
LL | let _s2 = S { a: 2, c: s0.c.clone(), ..s0 };
| +++++++++++++++++
```
```
error[E0509]: cannot move out of type `S<()>`, which implements the `Drop` trait
--> $DIR/borrowck-struct-update-with-dtor.rs:20:19
|
LL | let _s2 = S { a: 2, ..s0 };
| ^^^^^^^^^^^^^^^^
| |
| cannot move out of here
| move occurs because `s0.b` has type `B`, which does not implement the `Copy` trait
|
note: `B` doesn't implement `Copy` or `Clone`
--> $DIR/borrowck-struct-update-with-dtor.rs:4:1
|
LL | struct B;
| ^^^^^^^^
help: if `B` implemented `Clone`, you could clone the value from the field instead of using the spread operator syntax
|
LL | let _s2 = S { a: 2, b: s0.b.clone(), ..s0 };
| +++++++++++++++++
```
Suggest `.clone()` in some move errors2024-04-11T16:41:41+00:00Esteban Küberesteban@kuber.com.ar2024-03-13T03:41:41+00:00urn:sha1:10c2fbec2437a873463382726d4815520430ff1f
```
error[E0507]: cannot move out of `*x` which is behind a shared reference
--> $DIR/borrowck-fn-in-const-a.rs:6:16
|
LL | return *x
| ^^ move occurs because `*x` has type `String`, which does not implement the `Copy` trait
|
help: consider cloning the value if the performance cost is acceptable
|
LL - return *x
LL + return x.clone()
|
```
Show number in error message even for one error2023-11-24T18:15:52+00:00Nilstrieb48135649+Nilstrieb@users.noreply.github.com2023-11-21T15:44:16+00:00urn:sha1:41e8d152dc5abb5a706999ada8b059d3420af8f3
Co-authored-by: Adrian <adrian.iosdev@gmail.com>
Move /src/test to /tests2023-01-11T09:32:08+00:00Albert Larsan74931857+albertlarsan68@users.noreply.github.com2023-01-05T08:13:28+00:00urn:sha1:cf2dff2b1e3fa55fa5415d524200070d0d7aacfe