https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try-perf 2024-12-17T02:56:10+00:00 2024-12-17T02:56:10+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T02:57:46+00:00 urn:sha1:121e87bf1490f0258bdb354eb8c4e891ebb7e7e7 `CheckAttrVisitor::check_doc_keyword` checks `#[doc(keyword = "..")]` attributes to ensure they are on an empty module, and that the value is a non-empty identifier. The `rustc::existing_doc_keyword` lint checks these attributes to ensure that the value is the name of a keyword. It's silly to have two different checking mechanisms for these attributes. This commit does the following. - Changes `check_doc_keyword` to check that the value is the name of a keyword (avoiding the need for the identifier check, which removes a dependency on `rustc_lexer`). - Removes the lint. - Updates tests accordingly. There is one hack: the `SelfTy` FIXME case used to used to be handled by disabling the lint, but now is handled with a special case in `is_doc_keyword`. That hack will go away if/when the FIXME is fixed. Co-Authored-By: Guillaume Gomez <guillaume1.gomez@gmail.com> 2024-04-15T12:54:11+00:00 Ben Kimock kimockb@gmail.com 2024-04-14T20:23:07+00:00 urn:sha1:7457a0d4415f6198b35dc24b9026e81551f90669 2024-02-16T20:02:50+00:00 许杰友 Jieyou Xu (Joe) jieyouxu@outlook.com 2024-02-16T20:02:50+00:00 urn:sha1:ec2cc761bc7067712ecc7734502f703fe3b024c8 2023-11-24T18:15:52+00:00 Nilstrieb 48135649+Nilstrieb@users.noreply.github.com 2023-11-21T15:44:16+00:00 urn:sha1:41e8d152dc5abb5a706999ada8b059d3420af8f3 Co-authored-by: Adrian <adrian.iosdev@gmail.com> 2023-04-14T03:08:07+00:00 jyn jyn.nelson@redjack.com 2023-04-02T22:09:11+00:00 urn:sha1:2ffb0de8cfda57cafdfd71a690f14c2e17216d85 They pass fine. Only tests that required `extern crate rustc_*` or were marked `ignore-stage1` have been keep in fulldeps.