https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=master 2025-06-08T23:41:46+00:00 2025-06-08T23:41:46+00:00 Jubilee Young workingjubilee@gmail.com 2025-02-12T06:09:16+00:00 urn:sha1:2e1965831526407bada7abec631d7b7e9f6cbc7d In PR 90877 T-lang decided not to remove `intrinsics::pref_align_of`. However, the intrinsic and its supporting code 1. is a nightly feature, so can be removed at compiler/libs discretion 2. requires considerable effort in the compiler to support, as it necessarily complicates every single site reasoning about alignment 3. has been justified based on relevance to codegen, but it is only a requirement for C++ (not C, not Rust) stack frame layout for AIX, in ways Rust would not consider even with increased C++ interop 4. is only used by rustc to overalign some globals, not correctness 5. can be adequately replaced by other rules for globals, as it mostly affects alignments for a few types under 16 bytes of alignment 6. has only one clear benefactor: automating C -> Rust translation for GNU extensions like `__alignof` 7. such code was likely intended to be `alignof` or `_Alignof`, because the GNU extension is a "false friend" of the C keyword, which makes the choice to support such a mapping very questionable 8. makes it easy to do incorrect codegen in the compiler by its mere presence as usual Rust rules of alignment (e.g. `size == align * N`) do not hold with preferred alignment The implementation is clearly damaging the code quality of the compiler. Thus it is within the compiler team's purview to simply rip it out. If T-lang wishes to have this intrinsic restored for c2rust's benefit, it would have to use a radically different implementation that somehow does not cause internal incorrectness. Until then, remove the intrinsic and its supporting code, as one tool and an ill-considered GCC extension cannot justify risking correctness. Because we touch a fair amount of the compiler to change this at all, and unfortunately the duplication of AbiAndPrefAlign is deep-rooted, we keep an "AbiAlign" type which we can wean code off later. 2025-03-06T17:22:19+00:00 Michael Goulet michael@errs.io 2025-03-06T17:22:19+00:00 urn:sha1:73d033f5a12e9852d9664286a71e6508b90a6035 adjust Layout debug printing to match the internal field name The field got renamed a while ago, but the debug printing was not updated to match. 2025-02-28T15:32:15+00:00 Ralf Jung post@ralfj.de 2025-02-28T15:30:59+00:00 urn:sha1:476b0980f22f4a4de2102f2994da39600fc4546d 2025-02-24T09:26:54+00:00 David Wood david.wood2@arm.com 2025-02-24T09:26:54+00:00 urn:sha1:92eb4450fa1ae37a948178c9d14bfb145a69562d minicore makes it much easier to add new language items to all of the existing `no_core` tests. 2025-02-20T19:40:41+00:00 Zachary S zasample18+github@gmail.com 2025-01-26T03:28:54+00:00 urn:sha1:c33fb5ae854e8ac26d75e72b7cb31519730f51d6 2025-01-10T01:22:57+00:00 The 8472 git@infinite-source.de 2024-12-23T22:17:02+00:00 urn:sha1:d7fb729d393e40919adfa0738a205c24c821808d 2024-10-30T08:41:31+00:00 Jubilee Young workingjubilee@gmail.com 2024-10-30T06:21:20+00:00 urn:sha1:083a362dd113da1217f7eed0e48baa2c584ac641 2023-07-14T21:48:13+00:00 Erik Desjardins erikdesjardins@users.noreply.github.com 2023-07-14T21:48:13+00:00 urn:sha1:2daacf5af965090b885287f1d40e13ff5db724cf 2023-07-10T23:19:40+00:00 Erik Desjardins erikdesjardins@users.noreply.github.com 2023-06-15T02:39:11+00:00 urn:sha1:d1e764cb3bc961a4395164a36c4e0cfd57e681a1 2023-07-10T23:19:40+00:00 Erik Desjardins erikdesjardins@users.noreply.github.com 2023-06-11T21:05:26+00:00 urn:sha1:7e933b4e26947b04da70589110dacbdb2461e27d