rust/tests/ui/moves, branch try-perfhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try-perf2025-08-19T19:27:10+00:00bless tests with new lint messages2025-08-19T19:27:10+00:00Karol Zwolakkarolzwolak7@gmail.com2025-04-28T11:47:25+00:00urn:sha1:d14b83e378c421dd09320ace833a9d47848e3046Adjust error message grammar to be less awkward2025-08-14T16:50:07+00:00Jake Gouldingjake.goulding@gmail.com2025-08-14T16:50:07+00:00urn:sha1:65d329d189651f5f4612e87132ca6c041cf61ab4Point at the `Fn()` or `FnMut()` bound that coerced a closure, which caused a move error2025-08-10T19:22:49+00:00Esteban Küberesteban@kuber.com.ar2025-07-28T02:01:46+00:00urn:sha1:1aa5668d20d53976860d141a66aa727e425e1079
When encountering a move error involving a closure because the captured value isn't `Copy`, and the obligation comes from a bound on a type parameter that requires `Fn` or `FnMut`, we point at it and explain that an `FnOnce` wouldn't cause the move error.
```
error[E0507]: cannot move out of `foo`, a captured variable in an `Fn` closure
--> f111.rs:15:25
|
14 | fn do_stuff(foo: Option<Foo>) {
| --- ----------- move occurs because `foo` has type `Option<Foo>`, which does not implement the `Copy` trait
| |
| captured outer variable
15 | require_fn_trait(|| async {
| -- ^^^^^ `foo` is moved here
| |
| captured by this `Fn` closure
16 | if foo.map_or(false, |f| f.foo()) {
| --- variable moved due to use in coroutine
|
help: `Fn` and `FnMut` closures require captured values to be able to be consumed multiple times, but an `FnOnce` consume them only once
--> f111.rs:12:53
|
12 | fn require_fn_trait<F: Future<Output = ()>>(_: impl Fn() -> F) {}
| ^^^^^^^^^
help: consider cloning the value if the performance cost is acceptable
|
16 | if foo.clone().map_or(false, |f| f.foo()) {
| ++++++++
```
Rollup merge of #145191 - dianne:fix-borrow-suggestion-args, r=compiler-errors2025-08-10T09:45:56+00:00Stuart CookZalathar@users.noreply.github.com2025-08-10T09:45:56+00:00urn:sha1:934cb10f1b21be3a855951fb9b1f38094946aac8
`suggest_borrow_generic_arg`: use the correct generic args
The suggestion now gets calls' generic arguments from the callee's type to handle cases where the callee isn't an identifier expression. Fixes rust-lang/rust#145164.
Rollup merge of #144403 - Kivooeo:issue4, r=jieyouxu2025-08-10T09:45:48+00:00Stuart CookZalathar@users.noreply.github.com2025-08-10T09:45:48+00:00urn:sha1:62b406d4b185f28828df3e0df6b1aa1f560145df
`tests/ui/issues/`: The Issues Strike Back [4/N]
Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of https://github.com/rust-lang/rust/issues/133895.
r? ````````@jieyouxu````````
`suggest_borrow_generic_arg`: use the correct generic args2025-08-10T01:31:35+00:00diannediannes.gm@gmail.com2025-08-10T01:07:37+00:00urn:sha1:a70a312f172c9d74f0b01bd2a6e1d9d77bcf6771comments2025-08-09T11:27:20+00:00KivooeoKivooeo123@gmail.com2025-07-24T14:07:20+00:00urn:sha1:16765639b30741dde85da0dbcb44c343eb82b1a2Rehome tests/ui/issues/ tests [3/?]2025-08-04T20:43:53+00:00Oneiricalmanchot@videotron.ca2025-07-13T20:25:27+00:00urn:sha1:7196d8cd661b875401126a81641d2effc40b3d85Mention type that could be `Clone` but isn't in more cases2025-07-25T18:34:10+00:00Esteban Küberesteban@kuber.com.ar2025-07-20T03:15:20+00:00urn:sha1:11061831f703fdb5d05816860368e4b9ab4edee7
When encountering a moved value of a type that isn't `Clone` because of unmet obligations, but where all the unmet predicates reference crate-local types, mention them and suggest cloning, as we do in other cases already:
```
error[E0507]: cannot move out of `foo`, a captured variable in an `Fn` closure
--> f111.rs:14:25
|
13 | fn do_stuff(foo: Option<Foo>) {
| --- captured outer variable
14 | require_fn_trait(|| async {
| -- ^^^^^ `foo` is moved here
| |
| captured by this `Fn` closure
15 | if foo.map_or(false, |f| f.foo()) {
| ---
| |
| variable moved due to use in coroutine
| move occurs because `foo` has type `Option<Foo>`, which does not implement the `Copy` trait
|
note: if `Foo` implemented `Clone`, you could clone the value
--> f111.rs:4:1
|
4 | struct Foo;
| ^^^^^^^^^^ consider implementing `Clone` for this type
...
15 | if foo.map_or(false, |f| f.foo()) {
| --- you could clone this value
```
moved 34 tests to organized locations2025-07-25T10:34:28+00:00KivooeoKivooeo123@gmail.com2025-07-24T13:29:09+00:00urn:sha1:90bb5cacb5c1a5fe20ba821d28e7eb7a21e35d09