rust/tests/ui/on-unimplemented, branch stablehttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=stable2025-06-22T08:58:25+00:00Implement DesugaringKind::FormatLiteral2025-06-22T08:58:25+00:00mejrs59372212+mejrs@users.noreply.github.com2025-06-16T15:51:29+00:00urn:sha1:b1d18129d199c095372c39f75a5c3fb31ea166c2refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking2025-06-09T09:44:24+00:00mejrs59372212+mejrs@users.noreply.github.com2025-05-18T16:35:13+00:00urn:sha1:959d6de1a928061256bb845025597be11ddca2eado away with `_Self` and `TraitName` and check generic params for rustc_on_unimplemented2025-05-17T13:15:53+00:00mejrs59372212+mejrs@users.noreply.github.com2025-05-17T13:15:53+00:00urn:sha1:9ffd0bf75a30b4fce1ffa35732666a37a7e9a736Rollup merge of #140307 - mejrs:condition_parser, r=nnethercote2025-05-05T04:20:57+00:00Trevor Grosst.gross35@gmail.com2025-05-05T04:20:57+00:00urn:sha1:e9a50b8a0a01808ff135b2706d6f7093789c02e3
Refactor rustc_on_unimplemented's filter parser
Followup to https://github.com/rust-lang/rust/pull/139091; I plan on moving most of this code into `rustc_attr_parsing` at some point, but want to land this separately first.
I have taken care to preserve the original behavior as much as I could:
- All but one of the new error variants are replacements for the ones originally emitted by the cfg parsing machinery; so these errors are not "new".
- the `InvalidFlag` variant is new, this PR turns this (from being ignored and silently doing nothing) into an error:
```rust
#[rustc_on_unimplemented(on(something, message = "y"))]
//~^ ERROR invalid boolean flag
//~^^ NOTE expected one of `crate_local`, `direct` or `from_desugaring`, not `something`
trait InvalidFlag {}
```
This does not occur anywhere except in this test. I couldn't find a way that I liked to keep allowing this or to do nothing, erroring was the cleanest solution.
- There are a bunch of FIXME throughout this and the previous PR, I plan on addressing those in follow up prs..
Finally, this gets rid of the "longest" dependency in rustc:
Refactor rustc_on_unimplemented's filter parser2025-05-02T20:08:35+00:00mejrs59372212+mejrs@users.noreply.github.com2025-05-02T20:08:35+00:00urn:sha1:4671081bdbc73d35a465a150937b6d0ecd26087fFix comment describing what the test does2025-04-29T10:19:55+00:00mejrs59372212+mejrs@users.noreply.github.com2025-04-29T10:19:55+00:00urn:sha1:fc2cd77e114a651755f39f2d9dc5cec6911f4bd9Improve rustc_on_unimplemented ui test2025-04-21T22:19:49+00:00mejrs59372212+mejrs@users.noreply.github.com2025-04-21T22:19:49+00:00urn:sha1:d2d844c65dd120a9f3cab15d7519499fcc4130a0Remove rustc_on_unimplemented on impl tests2025-04-13T22:12:37+00:00mejrs59372212+mejrs@users.noreply.github.com2025-04-10T14:06:59+00:00urn:sha1:4a5369b476fb17aa2db05b5b551eca0cfa6b2c6bTest that `Self` properly works in filters2025-04-13T22:12:37+00:00mejrs59372212+mejrs@users.noreply.github.com2025-04-01T00:47:12+00:00urn:sha1:40e76c157548442fce755ec9cc2274aef11454baRaise errors on bad rustc_on_unimplemented format strings again2025-04-13T22:12:37+00:00mejrs59372212+mejrs@users.noreply.github.com2025-03-29T12:48:14+00:00urn:sha1:10ec5cbe96b8b1ba96fbacc207d6a2f0d19ca9e2