rust/tests/ui/pattern/rfc-3637-guard-patterns, branch tryhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try2025-05-21T13:38:08+00:00Rollup merge of #141267 - dianne:fix-141265, r=oli-obk2025-05-21T13:38:08+00:00Matthias Krüger476013+matthiaskrgr@users.noreply.github.com2025-05-21T13:38:08+00:00urn:sha1:af081a42473979d094f71460e3b3f5bd18c0bb08
only resolve top-level guard patterns' guards once
We resolve guard patterns' guards in `resolve_pattern_inner`, so to avoid resolving them multiple times, we must avoid doing so earlier. To accomplish this, `LateResolutionVisitor::visit_pat` contains a case for guard patterns that avoids visiting their guards while walking patterns.
This PR fixes #141265, which was due to `visit::walk_pat` being used instead; this meant guards at the top level of a pattern would be visited twice. e.g. it would ICE on `for x if x in [] {}`, but not `for (x if x) in [] {}`. `visit_pat` was already used for the guard pattern in the second example, on account of the top-level pattern being parens.
`gather_locals`: only visit guard pattern guards when checking the guard2025-05-20T06:18:08+00:00diannediannes.gm@gmail.com2025-05-20T06:18:08+00:00urn:sha1:c343b2a47c29bdfe4c611ba74f9c9e455f12539b
When checking a pattern with guards in it, `GatherLocalsVisitor` will
visit both the pattern (when type-checking the let, arm, or param
containing it) and the guard expression (when checking the guard
itself). This keeps it from visiting the guard when visiting the
pattern, since otherwise it would gather locals from the guard twice,
which would lead to a delayed bug: "evaluated expression more than
once".
only resolve top-level guard patterns' guards once2025-05-20T01:02:54+00:00diannediannes.gm@gmail.com2025-05-20T01:02:54+00:00urn:sha1:ed983c21842be5e84f11b745c0c04ea23baa5509
We resolve guard patterns' guards in `resolve_pattern_inner`, so to
avoid resolving them multiple times, we must avoid doing so earlier. To
accomplish this, `LateResolutionVisitor::visit_pat` contains a case for
guard patterns that avoids visiting their guards while walking patterns.
This fixes an ICE due to `visit::walk_pat` being used instead, which
meant guards at the top level of a pattern would be visited twice.
name resolution for guard patterns2025-05-18T11:21:57+00:00diannediannes.gm@gmail.com2025-05-07T13:59:30+00:00urn:sha1:f0b8ec1d71f055cbdb741565eaddabc93bf1ae75Address review comments2024-12-07T12:37:35+00:00Nadrierilnadrieril+git@gmail.com2024-12-07T11:49:08+00:00urn:sha1:2459dbb4bad87c38284b0a2ba4f2d6d37db99627