about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndreas Martens <andreasm@fastmail.fm>2013-08-17 22:42:31 +0200
committerAndreas Martens <andreasm@fastmail.fm>2013-08-17 22:42:31 +0200
commitc4b4cb36c83f1fe581dc9d20c25baa2d2ed23e42 (patch)
treeb88a182f805ce6a111b389689fa6676fe6f4098a
parent7503396070a8d69040e9998faf667c29c6a6f2cb (diff)
downloadrust-c4b4cb36c83f1fe581dc9d20c25baa2d2ed23e42.tar.gz
rust-c4b4cb36c83f1fe581dc9d20c25baa2d2ed23e42.zip
Fix segfault when calling tuple struct constructor as extern fn
Fixes #5315
-rw-r--r--src/librustc/middle/trans/expr.rs8
-rw-r--r--src/test/run-pass/tuple-struct-constructor-pointer.rs19
2 files changed, 25 insertions, 2 deletions
diff --git a/src/librustc/middle/trans/expr.rs b/src/librustc/middle/trans/expr.rs
index 04fd477a317..1ec067d271f 100644
--- a/src/librustc/middle/trans/expr.rs
+++ b/src/librustc/middle/trans/expr.rs
@@ -795,14 +795,18 @@ fn trans_def_dps_unadjusted(bcx: @mut Block, ref_expr: &ast::expr,
                 return bcx;
             }
         }
-        ast::def_struct(*) => {
+        ast::def_struct(def_id) => {
             let ty = expr_ty(bcx, ref_expr);
             match ty::get(ty).sty {
                 ty::ty_struct(did, _) if ty::has_dtor(ccx.tcx, did) => {
                     let repr = adt::represent_type(ccx, ty);
                     adt::trans_start_init(bcx, repr, lldest, 0);
                 }
-                _ => {}
+                ty::ty_bare_fn(*) => {
+                    let fn_data = callee::trans_fn_ref(bcx, def_id, ref_expr.id);
+                    Store(bcx, fn_data.llfn, lldest);
+                }
+                _ => ()
             }
             return bcx;
         }
diff --git a/src/test/run-pass/tuple-struct-constructor-pointer.rs b/src/test/run-pass/tuple-struct-constructor-pointer.rs
new file mode 100644
index 00000000000..ad2acc4ad4f
--- /dev/null
+++ b/src/test/run-pass/tuple-struct-constructor-pointer.rs
@@ -0,0 +1,19 @@
+// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+struct Foo(int);
+struct Bar(int, int);
+
+fn main() {
+    let f: extern fn(int) -> Foo = Foo;
+    let g: extern fn(int, int) -> Bar = Bar;
+    f(42);
+    g(4, 7);
+}