diff options
| author | Philipp Krones <hello@philkrones.com> | 2022-07-18 09:39:37 +0200 |
|---|---|---|
| committer | Philipp Krones <hello@philkrones.com> | 2022-07-18 09:39:37 +0200 |
| commit | 7d4daaa8fa71337fc78b1b7799d048d51a3b3fcd (patch) | |
| tree | bff228b4e1035020349d3d974500c5137b72161e /.github | |
| parent | f88a1399bb89f9c4f95fb4a1e6d9b5ab05f35201 (diff) | |
Merge commit 'fdb84cbfd25908df5683f8f62388f663d9260e39' into clippyup
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 12 | ||||
| -rw-r--r-- | .github/workflows/clippy_bors.yml | 6 |
2 files changed, 11 insertions, 7 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 780ee9d63df..9e49f60892d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,11 +3,15 @@ Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only includes internal changes, you can just write `changelog: none`. Otherwise, please write a short comment -explaining your change. Also, it's helpful for us that -the lint name is put into brackets `[]` and backticks `` ` ` ``, -e.g. ``[`lint_name`]``. +explaining your change. -If your PR fixes an issue, you can add "fixes #issue_number" into this +It's also helpful for us that the lint name is put within backticks (`` ` ` ``), +and then encapsulated by square brackets (`[]`), for example: +``` +changelog: [`lint_name`]: your change +``` + +If your PR fixes an issue, you can add `fixes #issue_number` into this PR description. This way the issue will be automatically closed when your PR is merged. diff --git a/.github/workflows/clippy_bors.yml b/.github/workflows/clippy_bors.yml index b8ea424ef34..97453303cd6 100644 --- a/.github/workflows/clippy_bors.yml +++ b/.github/workflows/clippy_bors.yml @@ -144,7 +144,7 @@ jobs: OS: ${{ runner.os }} metadata_collection: - needs: base + needs: changelog runs-on: ubuntu-latest steps: @@ -264,7 +264,7 @@ jobs: name: bors test finished if: github.event.pusher.name == 'bors' && success() runs-on: ubuntu-latest - needs: [changelog, base, integration_build, integration] + needs: [changelog, base, metadata_collection, integration_build, integration] steps: - name: Mark the job as successful @@ -274,7 +274,7 @@ jobs: name: bors test finished if: github.event.pusher.name == 'bors' && (failure() || cancelled()) runs-on: ubuntu-latest - needs: [changelog, base, integration_build, integration] + needs: [changelog, base, metadata_collection, integration_build, integration] steps: - name: Mark the job as a failure |