diff options
| author | Jacob Pratt <jacob@jhpratt.dev> | 2025-02-15 02:37:31 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-02-15 02:37:31 -0500 |
| commit | 221ba2dfd11bbba3537ca7dac9397a23d3b852e7 (patch) | |
| tree | a65a9a6ae653b36241d97faa0829c9346c0bccd3 | |
| parent | c133123102e57eb7556850b4c575e62ff5d36199 (diff) | |
| parent | b2197abcc6e12d6f39b5622d2a37ff16fd46af61 (diff) | |
| download | rust-221ba2dfd11bbba3537ca7dac9397a23d3b852e7.tar.gz rust-221ba2dfd11bbba3537ca7dac9397a23d3b852e7.zip | |
Rollup merge of #137029 - chenyukang:yukang-fix-unused-check, r=jieyouxu,compiler-errors
Remove unnecessary check code in unused_delims After PR #108297, we make sure there is no unmatched delims in early lint check.
| -rw-r--r-- | compiler/rustc_lint/src/unused.rs | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/compiler/rustc_lint/src/unused.rs b/compiler/rustc_lint/src/unused.rs index 5a00ac005db..7b43aac90c7 100644 --- a/compiler/rustc_lint/src/unused.rs +++ b/compiler/rustc_lint/src/unused.rs @@ -1,5 +1,4 @@ use std::iter; -use std::ops::ControlFlow; use rustc_ast as ast; use rustc_ast::util::{classify, parser}; @@ -781,29 +780,6 @@ trait UnusedDelimLint { right_pos: Option<BytePos>, is_kw: bool, ) { - // If `value` has `ExprKind::Err`, unused delim lint can be broken. - // For example, the following code caused ICE. - // This is because the `ExprKind::Call` in `value` has `ExprKind::Err` as its argument - // and this leads to wrong spans. #104897 - // - // ``` - // fn f(){(print!(รก - // ``` - use rustc_ast::visit::{Visitor, walk_expr}; - struct ErrExprVisitor; - impl<'ast> Visitor<'ast> for ErrExprVisitor { - type Result = ControlFlow<()>; - fn visit_expr(&mut self, expr: &'ast ast::Expr) -> ControlFlow<()> { - if let ExprKind::Err(_) = expr.kind { - ControlFlow::Break(()) - } else { - walk_expr(self, expr) - } - } - } - if ErrExprVisitor.visit_expr(value).is_break() { - return; - } let spans = match value.kind { ast::ExprKind::Block(ref block, None) if let [stmt] = block.stmts.as_slice() => stmt .span |
