about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-03-13 20:45:28 +0000
committerbors <bors@rust-lang.org>2023-03-13 20:45:28 +0000
commit22f247c6f3ed388cb702d01c2ff27da658a8b353 (patch)
treeb663bb80f0c6624740cef964d049264be355b98b
parent8efa635b40ce6569e12f4988b7a9bcb7f3f0ed0c (diff)
parent58884a30a0a89181ca6b5ea6c06560af93de0307 (diff)
downloadrust-22f247c6f3ed388cb702d01c2ff27da658a8b353.tar.gz
rust-22f247c6f3ed388cb702d01c2ff27da658a8b353.zip
Auto merge of #109094 - Nilstrieb:no-thin-lto-on-windows, r=jyn514
Revert "enable ThinLTO for rustc on x86_64-pc-windows-msvc dist builds"

This lead to a miscompilation in at least `char::is_whitespace` and probably in more unknown places.....

See #109067

This reverts commit 684663ed380d0e6a6e135aed9c6055ab4ba94ac8, PR #103591.
-rw-r--r--.github/workflows/ci.yml2
-rw-r--r--src/ci/github-actions/ci.yml1
2 files changed, 1 insertions, 2 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 44f789c592b..3873a020b75 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -443,7 +443,7 @@ jobs:
             os: windows-latest-xl
           - name: dist-x86_64-msvc
             env:
-              RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --host=x86_64-pc-windows-msvc --target=x86_64-pc-windows-msvc --enable-full-tools --enable-profiler --set rust.lto=thin"
+              RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --host=x86_64-pc-windows-msvc --target=x86_64-pc-windows-msvc --enable-full-tools --enable-profiler"
               SCRIPT: PGO_HOST=x86_64-pc-windows-msvc python src/ci/stage-build.py python x.py dist bootstrap --include-default-paths
               DIST_REQUIRE_ALL_TOOLS: 1
             os: windows-latest-xl
diff --git a/src/ci/github-actions/ci.yml b/src/ci/github-actions/ci.yml
index 11f1532bef5..b490b766663 100644
--- a/src/ci/github-actions/ci.yml
+++ b/src/ci/github-actions/ci.yml
@@ -673,7 +673,6 @@ jobs:
                 --target=x86_64-pc-windows-msvc
                 --enable-full-tools
                 --enable-profiler
-                --set rust.lto=thin
               SCRIPT: PGO_HOST=x86_64-pc-windows-msvc python src/ci/stage-build.py python x.py dist bootstrap --include-default-paths
               DIST_REQUIRE_ALL_TOOLS: 1
             <<: *job-windows-xl