diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2025-01-29 21:27:17 +1100 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2025-01-31 08:27:15 +1100 |
| commit | 2dbe9fd8a638c0440fcb140efd04383d9660a4eb (patch) | |
| tree | 6646bda5c3bfae2dfd473e46d064f728c124845a | |
| parent | f453f930abb5922df7b0a27fe1742bfbf3828fb3 (diff) | |
| download | rust-2dbe9fd8a638c0440fcb140efd04383d9660a4eb.tar.gz rust-2dbe9fd8a638c0440fcb140efd04383d9660a4eb.zip | |
Remove an out-of-date `FIXME` comment.
This comment made sense when this crate was called `rustc_typeck`, but makes less sense now that it's called `rustc_hir_analysis`. Especially given that `check_drop_impl` is only called within the crate.
| -rw-r--r-- | compiler/rustc_hir_analysis/src/check/dropck.rs | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/compiler/rustc_hir_analysis/src/check/dropck.rs b/compiler/rustc_hir_analysis/src/check/dropck.rs index 0876bb82848..d7dfe482da4 100644 --- a/compiler/rustc_hir_analysis/src/check/dropck.rs +++ b/compiler/rustc_hir_analysis/src/check/dropck.rs @@ -1,7 +1,3 @@ -// FIXME(@lcnr): Move this module out of `rustc_hir_analysis`. -// -// We don't do any drop checking during hir typeck. - use rustc_data_structures::fx::FxHashSet; use rustc_errors::codes::*; use rustc_errors::{ErrorGuaranteed, struct_span_code_err}; @@ -32,7 +28,10 @@ use crate::hir::def_id::{DefId, LocalDefId}; /// struct/enum definition for the nominal type itself (i.e. /// cannot do `struct S<T>; impl<T:Clone> Drop for S<T> { ... }`). /// -pub fn check_drop_impl(tcx: TyCtxt<'_>, drop_impl_did: DefId) -> Result<(), ErrorGuaranteed> { +pub(crate) fn check_drop_impl( + tcx: TyCtxt<'_>, + drop_impl_did: DefId, +) -> Result<(), ErrorGuaranteed> { match tcx.impl_polarity(drop_impl_did) { ty::ImplPolarity::Positive => {} ty::ImplPolarity::Negative => { |
