diff options
| author | 许杰友 Jieyou Xu (Joe) <jieyouxu@outlook.com> | 2024-08-15 05:13:05 +0000 |
|---|---|---|
| committer | 许杰友 Jieyou Xu (Joe) <jieyouxu@outlook.com> | 2024-08-15 05:13:05 +0000 |
| commit | 35785ef39fa01250f6c4db6bb08e239f55c308ee (patch) | |
| tree | 541aff9da5709f5486a6c32f7cffab9ea850e29c | |
| parent | 13a52890dde8cfeb95069d77c223ac37c0cf3a46 (diff) | |
| download | rust-35785ef39fa01250f6c4db6bb08e239f55c308ee.tar.gz rust-35785ef39fa01250f6c4db6bb08e239f55c308ee.zip | |
tests: re-enable `dump-ice-to-disk` for Windows
This test was previously flakey on `i686-mingw`, but since some modifications I could no longer make it fail on `i686-mingw`. See <https://github.com/rust-lang/rust/pull/128958> for multiple try job runs.
| -rw-r--r-- | tests/run-make/dump-ice-to-disk/rmake.rs | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tests/run-make/dump-ice-to-disk/rmake.rs b/tests/run-make/dump-ice-to-disk/rmake.rs index 48b4071e065..08767246b90 100644 --- a/tests/run-make/dump-ice-to-disk/rmake.rs +++ b/tests/run-make/dump-ice-to-disk/rmake.rs @@ -14,11 +14,14 @@ //! that `RUSTC_ICE_PATH` takes precedence and no ICE dump is emitted under `METRICS_PATH`. //! //! See <https://github.com/rust-lang/rust/pull/108714>. - -//@ ignore-windows -// FIXME(#128911): @jieyouxu: This test is sometimes for whatever forsaken reason flakey in -// `i686-mingw`, and I cannot reproduce it locally. The error messages upon assertion failure in -// this test is intentionally extremely verbose to aid debugging that issue. +//! +//! # Test history +//! +//! - The previous rmake.rs iteration of this test was flakey for unknown reason on `i686-mingw` +//! *specifically*, so assertion failures in this test was made extremely verbose to help +//! diagnose why the ICE messages was different *specifically* on `i686-mingw`. +//! - An attempt is made to re-enable this test on `i686-mingw` (by removing `ignore-windows`). If +//! this test is still flakey, please restore the `ignore-windows` directive. use std::cell::OnceCell; use std::path::{Path, PathBuf}; |