about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-12-23 06:55:31 +0000
committerbors <bors@rust-lang.org>2024-12-23 06:55:31 +0000
commit66bb586952e095b8ee52e40b7d63a9bb0d19c5a2 (patch)
tree624a90f87275c5710b7ff3b35ae3373ade45475a
parent0eca4dd3205a01dba4bd7b7c140ec370aff03440 (diff)
parent4dca485db6b0f552d7cee25b4a66f6c05acf9ce3 (diff)
downloadrust-66bb586952e095b8ee52e40b7d63a9bb0d19c5a2.tar.gz
rust-66bb586952e095b8ee52e40b7d63a9bb0d19c5a2.zip
Auto merge of #134608 - DianQK:disable-93775, r=jieyouxu
Add `ignore-rustc-debug-assertions` to `tests/ui/associated-consts/issue-93775.rs`

Closes #132111. Closes #133432.

I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack.

IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size).

After set `rust.debug-assertions` is true, the test case requires a larger call stack, so disable it on `rust.debug-assertions=true`.

r? jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
-rw-r--r--tests/ui/associated-consts/issue-93775.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/ui/associated-consts/issue-93775.rs b/tests/ui/associated-consts/issue-93775.rs
index d7416d03707..88e88b55987 100644
--- a/tests/ui/associated-consts/issue-93775.rs
+++ b/tests/ui/associated-consts/issue-93775.rs
@@ -1,6 +1,6 @@
-//@ ignore-windows-msvc
-// FIXME(#132111, #133432): this test is flaky on windows msvc, it sometimes fail but it sometimes
-// passes.
+//@ ignore-rustc-debug-assertions
+// Similar to stress testing, the test case requires a larger call stack,
+// so we ignore rustc's debug assertions.
 
 //@ build-pass
 // ignore-tidy-linelength