about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2023-04-28 22:56:46 +0200
committerGitHub <noreply@github.com>2023-04-28 22:56:46 +0200
commitafbb1881ab82c2eeba2c672cbe86a593b88564d6 (patch)
treeec3e7e351627ad1cacd399d4162749e04e29aa56
parent03da9dbea05a87b9cdf17668881cbc473dcaf237 (diff)
parentf1b88eab50b3853cb649cddd40448f13f27aa6a3 (diff)
downloadrust-afbb1881ab82c2eeba2c672cbe86a593b88564d6.tar.gz
rust-afbb1881ab82c2eeba2c672cbe86a593b88564d6.zip
Rollup merge of #110948 - TimNN:patch-1, r=WaffleLapkin
run-make test: using single quotes to not trigger the shell

This test got added in #110801.

I'm no expert on Makefiles, but IIUC this command is passed to the shell, which usually tries to execute commands specified in between backticks in double-quoted strings.

Using single quotes should fix this, I think. (Note: Waiting for CI to test this, since I only have a web browser available right now).

r? ``@jyn514``

cc ``@WaffleLapkin``

Since this is breaking our build bot, even if it is not directly LLVM related: ``@rustbot`` label: +llvm-main
-rw-r--r--tests/run-make/inaccessible-temp-dir/Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/run-make/inaccessible-temp-dir/Makefile b/tests/run-make/inaccessible-temp-dir/Makefile
index 25b7b87a15a..abdba4eb861 100644
--- a/tests/run-make/inaccessible-temp-dir/Makefile
+++ b/tests/run-make/inaccessible-temp-dir/Makefile
@@ -25,7 +25,7 @@ all:
 	# Run rustc with `-Ztemps-dir` set to a directory 
 	# *inside* the inaccessible one, so that it can't create it
 	$(RUSTC) program.rs -Ztemps-dir=$(TMPDIR)/inaccessible/tmp 2>&1 \
-		| $(CGREP) "failed to find or create the directory specified by `--temps-dir`"
+		| $(CGREP) 'failed to find or create the directory specified by `--temps-dir`'
 
 	# Make the inaccessible directory accessible,
 	# so that compiletest can delete the temp dir