diff options
| author | David Wood <david.wood@huawei.com> | 2022-06-28 13:55:12 +0100 |
|---|---|---|
| committer | David Wood <david.wood@huawei.com> | 2022-06-30 08:59:22 +0100 |
| commit | dbced105db2b417d40b90a55c4c1a68a4f0ee6aa (patch) | |
| tree | 8acde3b2079fb51c6c83064451c87efeff946361 | |
| parent | 23ee3e09141fd01ba3ec648123aa319810867c86 (diff) | |
| download | rust-dbced105db2b417d40b90a55c4c1a68a4f0ee6aa.tar.gz rust-dbced105db2b417d40b90a55c4c1a68a4f0ee6aa.zip | |
lint: port unreachable `pub` diagnostic
Signed-off-by: David Wood <david.wood@huawei.com>
| -rw-r--r-- | compiler/rustc_error_messages/locales/en-US/lint.ftl | 4 | ||||
| -rw-r--r-- | compiler/rustc_lint/src/builtin.rs | 7 |
2 files changed, 8 insertions, 3 deletions
diff --git a/compiler/rustc_error_messages/locales/en-US/lint.ftl b/compiler/rustc_error_messages/locales/en-US/lint.ftl index 7c6a17aec58..34ce4b9d967 100644 --- a/compiler/rustc_error_messages/locales/en-US/lint.ftl +++ b/compiler/rustc_error_messages/locales/en-US/lint.ftl @@ -354,3 +354,7 @@ lint-builtin-mutable-transmutes = transmuting &T to &mut T is undefined behavior, even if the reference is unused, consider instead using an UnsafeCell lint-builtin-unstable-features = unstable feature + +lint-builtin-unreachable-pub = unreachable `pub` {$what} + .suggestion = consider restricting its visibility + .help = or consider exporting it for use by other crates diff --git a/compiler/rustc_lint/src/builtin.rs b/compiler/rustc_lint/src/builtin.rs index 4787d2ee92a..6c219366291 100644 --- a/compiler/rustc_lint/src/builtin.rs +++ b/compiler/rustc_lint/src/builtin.rs @@ -1385,16 +1385,17 @@ impl UnreachablePub { } let def_span = cx.tcx.sess.source_map().guess_head_span(span); cx.struct_span_lint(UNREACHABLE_PUB, def_span, |lint| { - let mut err = lint.build(&format!("unreachable `pub` {}", what)); + let mut err = lint.build(fluent::lint::builtin_unreachable_pub); + err.set_arg("what", what); err.span_suggestion( vis_span, - "consider restricting its visibility", + fluent::lint::suggestion, "pub(crate)", applicability, ); if exportable { - err.help("or consider exporting it for use by other crates"); + err.help(fluent::lint::help); } err.emit(); }); |