about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-11-16 00:40:04 +0000
committerbors <bors@rust-lang.org>2020-11-16 00:40:04 +0000
commitf4d014cee77f9112b2582d86085631c74413eb1e (patch)
treed62c5a8cd656f90229098db14c5f5e87ed42b472
parent603ab5bd6e0ffefafa7411cd8bd23a6ca82bcff0 (diff)
parent4feaa35f395ab6b649c7cf46671c37492ff8247f (diff)
downloadrust-f4d014cee77f9112b2582d86085631c74413eb1e.tar.gz
rust-f4d014cee77f9112b2582d86085631c74413eb1e.zip
Auto merge of #79074 - Mark-Simulacrum:fix-ci-llvm, r=jyn514
Install CI llvm into the library directory

In other words, my concern in https://github.com/rust-lang/rust/issues/78932#issuecomment-725781767 was perfectly justified by something we were already doing. For now just special case CI LLVM, but in the future we may want a more general fix.

Fixes #79071.

r? `@alexcrichton`
-rw-r--r--src/bootstrap/dist.rs5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/bootstrap/dist.rs b/src/bootstrap/dist.rs
index 514be9e6864..9b77e38a847 100644
--- a/src/bootstrap/dist.rs
+++ b/src/bootstrap/dist.rs
@@ -2358,7 +2358,7 @@ fn maybe_install_llvm(builder: &Builder<'_>, target: TargetSelection, dst_libdir
     }
 
     if let Some(config) = builder.config.target_config.get(&target) {
-        if config.llvm_config.is_some() {
+        if config.llvm_config.is_some() && !builder.config.llvm_from_ci {
             // If the LLVM was externally provided, then we don't currently copy
             // artifacts into the sysroot. This is not necessarily the right
             // choice (in particular, it will require the LLVM dylib to be in
@@ -2369,6 +2369,9 @@ fn maybe_install_llvm(builder: &Builder<'_>, target: TargetSelection, dst_libdir
             // with the wrong files and isn't what distributions want.
             //
             // This behavior may be revisited in the future though.
+            //
+            // If the LLVM is coming from ourselves (just from CI) though, we
+            // still want to install it, as it otherwise won't be available.
             return;
         }
     }