about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAda Alakbarova <ada.alakbarova@proton.me>2025-08-21 00:00:25 +0200
committerAda Alakbarova <ada.alakbarova@proton.me>2025-08-22 15:03:14 +0200
commitf51b5afd5043c5514c0eccd9e8083694bfea967b (patch)
tree5588a51e32018b10616b7b0c5915caabc3f6b6a8
parent5abee438bcd8bb2882464aeaf7afe7dd4f9d4426 (diff)
downloadrust-f51b5afd5043c5514c0eccd9e8083694bfea967b.tar.gz
rust-f51b5afd5043c5514c0eccd9e8083694bfea967b.zip
is_default_equivalent_ctor: check for String once
-rw-r--r--clippy_utils/src/lib.rs7
1 files changed, 4 insertions, 3 deletions
diff --git a/clippy_utils/src/lib.rs b/clippy_utils/src/lib.rs
index 8533fa85541..7a2c1bf40d9 100644
--- a/clippy_utils/src/lib.rs
+++ b/clippy_utils/src/lib.rs
@@ -640,9 +640,10 @@ fn is_default_equivalent_ctor(cx: &LateContext<'_>, def_id: DefId, path: &QPath<
         && let Some(impl_did) = cx.tcx.impl_of_assoc(def_id)
         && let Some(adt) = cx.tcx.type_of(impl_did).instantiate_identity().ty_adt_def()
     {
-        return std_types_symbols.iter().any(|&symbol| {
-            cx.tcx.is_diagnostic_item(symbol, adt.did()) || Some(adt.did()) == cx.tcx.lang_items().string()
-        });
+        return Some(adt.did()) == cx.tcx.lang_items().string()
+            || std_types_symbols
+                .iter()
+                .any(|&symbol| cx.tcx.is_diagnostic_item(symbol, adt.did()));
     }
     false
 }