diff options
| author | Jana Dönszelmann <jonathan@donsz.nl> | 2025-07-03 13:29:37 +0200 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-03 13:29:37 +0200 | 
| commit | 622722aadaa2dba9aa9caed65006cd97ea3f9f35 (patch) | |
| tree | 99f92ba28b44c0b3cdc9ec80d2cd0d47f485c54e | |
| parent | 0aaac883de0b16b6ec60b48038913e05eff5cc2f (diff) | |
| parent | 58418d881a91e9f37b0c8fd07f0218850725efda (diff) | |
| download | rust-622722aadaa2dba9aa9caed65006cd97ea3f9f35.tar.gz rust-622722aadaa2dba9aa9caed65006cd97ea3f9f35.zip | |
Rollup merge of #143083 - JonathanBrouwer:rustdoc-fix, r=jdonszelmann
Fix rustdoc not correctly showing attributes on re-exports Fixes attributes not being shown correctly in rustdoc on re-exports Does this need to be backported to beta? r? ``@jdonszelmann``
| -rw-r--r-- | src/librustdoc/clean/mod.rs | 3 | ||||
| -rw-r--r-- | tests/rustdoc/attributes-re-export.rs | 13 | 
2 files changed, 15 insertions, 1 deletions
| diff --git a/src/librustdoc/clean/mod.rs b/src/librustdoc/clean/mod.rs index 744da14748d..93d0e76b56f 100644 --- a/src/librustdoc/clean/mod.rs +++ b/src/librustdoc/clean/mod.rs @@ -2746,7 +2746,8 @@ fn add_without_unwanted_attributes<'hir>( attrs.push((Cow::Owned(attr), import_parent)); } } - hir::Attribute::Parsed(..) if is_inline => { + // FIXME: make sure to exclude `#[cfg_trace]` here when it is ported to the new parsers + hir::Attribute::Parsed(..) => { attrs.push((Cow::Owned(attr), import_parent)); } _ => {} diff --git a/tests/rustdoc/attributes-re-export.rs b/tests/rustdoc/attributes-re-export.rs new file mode 100644 index 00000000000..458826ea8a3 --- /dev/null +++ b/tests/rustdoc/attributes-re-export.rs @@ -0,0 +1,13 @@ +// Tests that attributes are correctly copied onto a re-exported item. +//@ edition:2021 +#![crate_name = "re_export"] + +//@ has 're_export/fn.thingy2.html' '//pre[@class="rust item-decl"]' '#[no_mangle]' +pub use thingymod::thingy as thingy2; + +mod thingymod { + #[no_mangle] + pub fn thingy() { + + } +} | 
