diff options
| author | Jana Dönszelmann <jana@donsz.nl> | 2025-09-12 13:54:15 -0700 |
|---|---|---|
| committer | Jana Dönszelmann <jana@donsz.nl> | 2025-09-13 10:12:18 -0700 |
| commit | 365189ef4f508e4645de7607052884b8e7f413a3 (patch) | |
| tree | 6a4f538bb42f2dbbfad9b5f4a10a80f94df3a304 | |
| parent | 7ad23f43a225546c095123de52cc07d8719f8e2b (diff) | |
| download | rust-365189ef4f508e4645de7607052884b8e7f413a3.tar.gz rust-365189ef4f508e4645de7607052884b8e7f413a3.zip | |
update fixme in compare_method_predicate_entailment resulting from review of EII
| -rw-r--r-- | compiler/rustc_hir_analysis/src/check/compare_impl_item.rs | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs b/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs index e4827256193..222fe7b5932 100644 --- a/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs +++ b/compiler/rustc_hir_analysis/src/check/compare_impl_item.rs @@ -298,14 +298,9 @@ fn compare_method_predicate_entailment<'tcx>( // compatible with that of the trait method. We do this by // checking that `impl_fty <: trait_fty`. // - // FIXME. Unfortunately, this doesn't quite work right now because - // associated type normalization is not integrated into subtype - // checks. For the comparison to be valid, we need to - // normalize the associated types in the impl/trait methods - // first. However, because function types bind regions, just - // calling `FnCtxt::normalize` would have no effect on - // any associated types appearing in the fn arguments or return - // type. + // FIXME: We manually instantiate the trait method here as we need + // to manually compute its implied bounds. Otherwise this could just + // be `ocx.sub(impl_sig, trait_sig)`. let mut wf_tys = FxIndexSet::default(); |
