about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJason Newcomb <jsnewcomb@pm.me>2024-06-13 18:26:38 -0400
committerJason Newcomb <jsnewcomb@pm.me>2024-07-07 18:11:43 -0400
commit5d333e862b5a2df69333952c331cdb06b4fd12e4 (patch)
tree55addb5c39bf3ad33c28e70793150e65106fbbb1
parentc0068ba5acad7c74111006e90ca2d310d111129c (diff)
downloadrust-5d333e862b5a2df69333952c331cdb06b4fd12e4.tar.gz
rust-5d333e862b5a2df69333952c331cdb06b4fd12e4.zip
`manual_strip`: Delay msrv check.
-rw-r--r--clippy_lints/src/manual_strip.rs7
1 files changed, 2 insertions, 5 deletions
diff --git a/clippy_lints/src/manual_strip.rs b/clippy_lints/src/manual_strip.rs
index 45af9f07718..6a523ad1564 100644
--- a/clippy_lints/src/manual_strip.rs
+++ b/clippy_lints/src/manual_strip.rs
@@ -66,14 +66,11 @@ enum StripKind {
 
 impl<'tcx> LateLintPass<'tcx> for ManualStrip {
     fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
-        if !self.msrv.meets(msrvs::STR_STRIP_PREFIX) {
-            return;
-        }
-
         if let Some(higher::If { cond, then, .. }) = higher::If::hir(expr)
             && let ExprKind::MethodCall(_, target_arg, [pattern], _) = cond.kind
-            && let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(cond.hir_id)
             && let ExprKind::Path(target_path) = &target_arg.kind
+            && self.msrv.meets(msrvs::STR_STRIP_PREFIX)
+            && let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(cond.hir_id)
         {
             let strip_kind = if match_def_path(cx, method_def_id, &paths::STR_STARTS_WITH) {
                 StripKind::Prefix