diff options
| author | Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer <github35764891676564198441@oli-obk.de> | 2018-11-24 10:16:38 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-24 10:16:38 +0100 |
| commit | 69d09fbfc6fe10dd20cf27f737e7ff6175e2c642 (patch) | |
| tree | 042c70006f417edf3cf897dc74225749310a4da4 | |
| parent | 3e68a89dd0ec3a5fa3792e32392e9331afcd1cb0 (diff) | |
| parent | e4be2b4e6411d1b144305adab6b8874d7d3448d9 (diff) | |
| download | rust-69d09fbfc6fe10dd20cf27f737e7ff6175e2c642.tar.gz rust-69d09fbfc6fe10dd20cf27f737e7ff6175e2c642.zip | |
Merge pull request #3439 from dtolnay/npbv
Downgrade needless_pass_by_value to allow by default
| -rw-r--r-- | clippy_lints/src/lib.rs | 3 | ||||
| -rw-r--r-- | clippy_lints/src/needless_pass_by_value.rs | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index 3debe567cda..2dbe448c950 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -509,6 +509,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { misc_early::UNSEPARATED_LITERAL_SUFFIX, mut_mut::MUT_MUT, needless_continue::NEEDLESS_CONTINUE, + needless_pass_by_value::NEEDLESS_PASS_BY_VALUE, non_expressive_names::SIMILAR_NAMES, replace_consts::REPLACE_CONSTS, shadow::SHADOW_UNRELATED, @@ -671,7 +672,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { needless_bool::BOOL_COMPARISON, needless_bool::NEEDLESS_BOOL, needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE, - needless_pass_by_value::NEEDLESS_PASS_BY_VALUE, needless_update::NEEDLESS_UPDATE, neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD, neg_multiply::NEG_MULTIPLY, @@ -809,7 +809,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { misc_early::MIXED_CASE_HEX_LITERALS, misc_early::UNNEEDED_FIELD_PATTERN, mut_reference::UNNECESSARY_MUT_PASSED, - needless_pass_by_value::NEEDLESS_PASS_BY_VALUE, neg_multiply::NEG_MULTIPLY, new_without_default::NEW_WITHOUT_DEFAULT, new_without_default::NEW_WITHOUT_DEFAULT_DERIVE, diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs index d4257fd1aa9..ff8e0cc0e6e 100644 --- a/clippy_lints/src/needless_pass_by_value.rs +++ b/clippy_lints/src/needless_pass_by_value.rs @@ -54,7 +54,7 @@ use crate::rustc_errors::Applicability; /// ``` declare_clippy_lint! { pub NEEDLESS_PASS_BY_VALUE, - style, + pedantic, "functions taking arguments by value, but not consuming them in its body" } |