diff options
| author | Jacob Pratt <jacob@jhpratt.dev> | 2025-08-22 22:00:53 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-22 22:00:53 -0400 |
| commit | 77f980f20278d44fa5d08070db3e4bc79131fb25 (patch) | |
| tree | ae5fc7396d2c154e4f1d622dd40927bc36c4a916 | |
| parent | 15eeddee1f5a6ae523ef9aa74f0a50169a137e08 (diff) | |
| parent | 53b775d9c6664aebc1526cf2ac300566da24262a (diff) | |
| download | rust-77f980f20278d44fa5d08070db3e4bc79131fb25.tar.gz rust-77f980f20278d44fa5d08070db3e4bc79131fb25.zip | |
Rollup merge of #145669 - notriddle:test-js-search-scripts-path, r=GuillaumeGomez
rustdoc-search: GUI tests check for `//` in URL
Follow up https://github.com/rust-lang/rust/pull/145650
When this fails, you get output that looks like:
/home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` around line 49
from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event
Making the error message more informative requires patching browser-ui-test.
| -rw-r--r-- | tests/rustdoc-gui/utils.goml | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tests/rustdoc-gui/utils.goml b/tests/rustdoc-gui/utils.goml index 10439309402..e13aef6712f 100644 --- a/tests/rustdoc-gui/utils.goml +++ b/tests/rustdoc-gui/utils.goml @@ -39,6 +39,13 @@ define-function: ( "perform-search", [query], block { + // Block requests with doubled `//`. + // Amazon S3 doesn't support them, but other web hosts do, + // and so do file:/// URLs, which means we need to block + // it here if we want to avoid breaking the main docs site. + // https://github.com/rust-lang/rust/issues/145646 + block-network-request: "file://*//*" + // Perform search click: "#search-button" wait-for: ".search-input" write-into: (".search-input", |query|) |