diff options
| author | Chayim Refael Friedman <chayimfr@gmail.com> | 2025-06-17 12:48:19 +0300 |
|---|---|---|
| committer | Chayim Refael Friedman <chayimfr@gmail.com> | 2025-06-17 12:48:19 +0300 |
| commit | a1aac53d6fa72e89efd4881dcf80a8b74469c201 (patch) | |
| tree | 7d38adabac900f7b719b419fd2b863653dc8044e | |
| parent | 3341b654638a7b7d03ca66c5290651f5751110eb (diff) | |
| download | rust-a1aac53d6fa72e89efd4881dcf80a8b74469c201.tar.gz rust-a1aac53d6fa72e89efd4881dcf80a8b74469c201.zip | |
Never make type mismatch diagnostic stable, even when there is a fix
We show fixes now even for experimental diagnostics anyway, and it has false positives.
| -rw-r--r-- | src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs b/src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs index 7b4c249554d..e2957fcaefb 100644 --- a/src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs +++ b/src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/type_mismatch.rs @@ -39,7 +39,7 @@ pub(crate) fn type_mismatch(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch< cov_mark::hit!(type_mismatch_range_adjustment); Some(salient_token_range) }); - let mut diag = Diagnostic::new( + Diagnostic::new( DiagnosticCode::RustcHardError("E0308"), format!( "expected {}, found {}", @@ -52,11 +52,7 @@ pub(crate) fn type_mismatch(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch< ), display_range, ) - .with_fixes(fixes(ctx, d)); - if diag.fixes.is_some() { - diag.experimental = false; - } - diag + .with_fixes(fixes(ctx, d)) } fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch<'_>) -> Option<Vec<Assist>> { |
