about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNoah Lev <camelidcamel@gmail.com>2021-10-29 20:57:12 -0700
committerNoah Lev <camelidcamel@gmail.com>2021-10-30 11:16:26 -0700
commita58e21489424de9ce1fb48c2d4a7113dcd62f095 (patch)
tree86952fbdcf292ca26cb1d8b8fb8b06be49ea4d8e
parentebe9a11f71f2998e0be4d9b95f4eac5d1e1f82a0 (diff)
downloadrust-a58e21489424de9ce1fb48c2d4a7113dcd62f095.tar.gz
rust-a58e21489424de9ce1fb48c2d4a7113dcd62f095.zip
rustdoc: Stop sorting external crates
Now that #73423 is fixed, sorting should no longer be necessary.
See also this discussion [1].

[1]: https://github.com/rust-lang/rust/pull/86889#discussion_r664134963
-rw-r--r--src/librustdoc/clean/utils.rs3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/librustdoc/clean/utils.rs b/src/librustdoc/clean/utils.rs
index b0da92081c1..2fae3163a1a 100644
--- a/src/librustdoc/clean/utils.rs
+++ b/src/librustdoc/clean/utils.rs
@@ -29,12 +29,11 @@ crate fn krate(cx: &mut DocContext<'_>) -> Crate {
     let module = crate::visit_ast::RustdocVisitor::new(cx).visit();
 
     let mut externs = Vec::new();
-    for &cnum in cx.tcx.crates(()).iter() {
+    for &cnum in cx.tcx.crates(()) {
         externs.push(ExternalCrate { crate_num: cnum });
         // Analyze doc-reachability for extern items
         LibEmbargoVisitor::new(cx).visit_lib(cnum);
     }
-    externs.sort_unstable_by_key(|e| e.crate_num);
 
     // Clean the crate, translating the entire librustc_ast AST to one that is
     // understood by rustdoc.