about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDylan DPC <dylan.dpc@gmail.com>2021-01-13 03:20:25 +0100
committerGitHub <noreply@github.com>2021-01-13 03:20:25 +0100
commitc64d3f0afccc3a8d67eb1fd01b287b77192108b4 (patch)
tree6efca3d0148990a77ba7ee2e1642c5f55d5afec9
parentd64e703e4fb52479d432b81a369e64246ee5c433 (diff)
parentf3c8f29b3bf784b27e212d289065c5dd1c4cc5fe (diff)
downloadrust-c64d3f0afccc3a8d67eb1fd01b287b77192108b4.tar.gz
rust-c64d3f0afccc3a8d67eb1fd01b287b77192108b4.zip
Rollup merge of #80924 - teryror:issue-80893-fix, r=jyn514
Fix rustdoc --test-builder argument parsing

My suggested fix to issue #80893. I can actually hook Miri in there now.

I also fixed what I believe to be a typo in the option's help text.
-rw-r--r--src/librustdoc/lib.rs6
-rw-r--r--src/test/rustdoc/issue-80893.rs6
2 files changed, 7 insertions, 5 deletions
diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs
index 7ed64c5813f..efcb006870c 100644
--- a/src/librustdoc/lib.rs
+++ b/src/librustdoc/lib.rs
@@ -412,11 +412,7 @@ fn opts() -> Vec<RustcOptGroup> {
             )
         }),
         unstable("test-builder", |o| {
-            o.optflag(
-                "",
-                "test-builder",
-                "specified the rustc-like binary to use as the test builder",
-            )
+            o.optopt("", "test-builder", "The rustc-like binary to use as the test builder", "PATH")
         }),
         unstable("check", |o| o.optflag("", "check", "Run rustdoc checks")),
     ]
diff --git a/src/test/rustdoc/issue-80893.rs b/src/test/rustdoc/issue-80893.rs
new file mode 100644
index 00000000000..7c958a80be3
--- /dev/null
+++ b/src/test/rustdoc/issue-80893.rs
@@ -0,0 +1,6 @@
+// compile-flags: --test -Z unstable-options --test-builder true
+
+/// ```no_run
+/// This tests that `--test-builder` is accepted as a flag by rustdoc.
+/// ```
+pub struct Foo;