diff options
| author | bors <bors@rust-lang.org> | 2024-09-28 20:15:04 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-09-28 20:15:04 +0000 |
| commit | ed04567ba1d5956d1080fb8121caa005ce059e12 (patch) | |
| tree | 03b3d43120b71e70897791cede9e895244729459 | |
| parent | a1fd2351803fd7db9c70093e19c63e11eded953c (diff) | |
| parent | 404c5d26c9aa37899fe00a5e66fdc5178fc9e0ea (diff) | |
| download | rust-ed04567ba1d5956d1080fb8121caa005ce059e12.tar.gz rust-ed04567ba1d5956d1080fb8121caa005ce059e12.zip | |
Auto merge of #129385 - tgross35:more-platforms-enable-f16, r=Mark-Simulacrum
Enable `f16` tests on platforms that were missing conversion symbols The only requirement for `f16` support, aside from LLVM not crashing and no ABI issues, is that symbols to convert to and from `f32` are available. Since the update to compiler-builtins in https://github.com/rust-lang/rust/pull/125016, we now provide these on all platforms. This also enables `f16` math since there are no further requirements. Still excluded are platforms for which LLVM emits infinitely-recursing code. try-job: arm-android try-job: test-various try-job: x86_64-fuchsia
| -rw-r--r-- | library/std/build.rs | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/library/std/build.rs b/library/std/build.rs index 359ae4f20ee..c5d0af469a8 100644 --- a/library/std/build.rs +++ b/library/std/build.rs @@ -96,9 +96,6 @@ fn main() { let has_reliable_f16 = match (target_arch.as_str(), target_os.as_str()) { // We can always enable these in Miri as that is not affected by codegen bugs. _ if is_miri => true, - // Selection failure until recent LLVM <https://github.com/llvm/llvm-project/issues/93894> - // FIXME(llvm19): can probably be removed at the version bump - ("loongarch64", _) => false, // Selection failure <https://github.com/llvm/llvm-project/issues/50374> ("s390x", _) => false, // Unsupported <https://github.com/llvm/llvm-project/issues/94434> @@ -108,18 +105,18 @@ fn main() { // Apple has a special ABI for `f16` that we do not yet support // FIXME(builtins): fixed by <https://github.com/rust-lang/compiler-builtins/pull/675> ("x86" | "x86_64", _) if target_vendor == "apple" => false, - // Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee` + // Infinite recursion <https://github.com/llvm/llvm-project/issues/97981> + ("csky", _) => false, + ("hexagon", _) => false, + ("loongarch64", _) => false, + ("mips" | "mips64" | "mips32r6" | "mips64r6", _) => false, ("powerpc" | "powerpc64", _) => false, - // Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee` - ("mips" | "mips32r6" | "mips64" | "mips64r6", _) => false, - // Missing `__extendhfsf` and `__truncsfhf` - ("riscv32" | "riscv64", _) => false, - // Most OSs are missing `__extendhfsf` and `__truncsfhf` - (_, "linux" | "macos") => true, - // Almost all OSs besides Linux and MacOS are missing symbols until compiler-builtins can - // be updated. <https://github.com/rust-lang/rust/pull/125016> will get some of these, the - // next CB update should get the rest. - _ => false, + ("sparc" | "sparc64", _) => false, + ("wasm32" | "wasm64", _) => false, + // `f16` support only requires that symbols converting to and from `f32` are available. We + // provide these in `compiler-builtins`, so `f16` should be available on all platforms that + // do not have other ABI issues or LLVM crashes. + _ => true, }; let has_reliable_f128 = match (target_arch.as_str(), target_os.as_str()) { |
