about summary refs log tree commit diff
diff options
context:
space:
mode:
authorBrian Anderson <banderson@mozilla.com>2011-08-29 11:29:25 -0700
committerBrian Anderson <andersrb@gmail.com>2011-08-30 21:08:07 -0700
commit04928ed3f00e82d7d233d2b4d2a63440f098b279 (patch)
treef8ed0f88d9833a15b00e763b7f945d6c07d269af
parentc94d4cff0314459f93e086b3ef0fd89f3f368f35 (diff)
downloadrust-04928ed3f00e82d7d233d2b4d2a63440f098b279.tar.gz
rust-04928ed3f00e82d7d233d2b4d2a63440f098b279.zip
Add a FIXME about the bogosity of aio::ip_to_sbuf
-rw-r--r--src/lib/aio.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/lib/aio.rs b/src/lib/aio.rs
index 791480a7a86..e1c8625352b 100644
--- a/src/lib/aio.rs
+++ b/src/lib/aio.rs
@@ -45,6 +45,9 @@ tag request {
 type ctx = chan<request>;
 
 fn ip_to_sbuf(ip: net::ip_addr) -> *u8 {
+    // FIXME: This is broken. We're creating a vector, getting a pointer
+    // to its buffer, then dropping the vector. On top of that, the vector
+    // created by istr::bytes is not null-terminated.
     vec::to_ptr(istr::bytes(net::format_addr(ip)))
 }