about summary refs log tree commit diff
diff options
context:
space:
mode:
authorBrian Anderson <andersrb@gmail.com>2013-01-14 14:11:26 -0800
committerBrian Anderson <andersrb@gmail.com>2013-01-14 14:11:26 -0800
commit0ca369e9dc5f6ea0ba0c38d047e8d931badfc82c (patch)
tree0c8e65f64626cbc0c0e13f48647b8c5c70a2e2ca
parent3962dec67cc8f48b47c7efce29416144365d772c (diff)
parente368b16f823d627db7d91d5c4fb8598bbb69233c (diff)
downloadrust-0ca369e9dc5f6ea0ba0c38d047e8d931badfc82c.tar.gz
rust-0ca369e9dc5f6ea0ba0c38d047e8d931badfc82c.zip
Merge pull request #4485 from sanxiyn/use-truncate
Use vec::truncate for vec::retain
-rw-r--r--src/libcore/vec.rs5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/libcore/vec.rs b/src/libcore/vec.rs
index 092aea7577f..49a0e5b2109 100644
--- a/src/libcore/vec.rs
+++ b/src/libcore/vec.rs
@@ -895,9 +895,8 @@ pub fn retain<T>(v: &mut ~[T], f: pure fn(t: &T) -> bool) {
         }
     }
 
-    while deleted > 0 {
-        v.pop();
-        deleted -= 1;
+    if deleted > 0 {
+        v.truncate(len - deleted);
     }
 }