about summary refs log tree commit diff
diff options
context:
space:
mode:
authorCentri3 <114838443+Centri3@users.noreply.github.com>2023-06-11 09:43:26 -0500
committerCentri3 <114838443+Centri3@users.noreply.github.com>2023-06-11 09:43:26 -0500
commit108c04acf0bdb90e68ec7c12e86c5fbb21548061 (patch)
treee97d1f962d0d497c25375da57278ee52a68db309
parentd989f432a4c73be55aff9434001d510f6b30c013 (diff)
downloadrust-108c04acf0bdb90e68ec7c12e86c5fbb21548061.tar.gz
rust-108c04acf0bdb90e68ec7c12e86c5fbb21548061.zip
Stop visiting once it's found `Let`
-rw-r--r--clippy_lints/src/needless_if.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/clippy_lints/src/needless_if.rs b/clippy_lints/src/needless_if.rs
index b118516e09b..dbffbd6f0d3 100644
--- a/clippy_lints/src/needless_if.rs
+++ b/clippy_lints/src/needless_if.rs
@@ -96,8 +96,8 @@ impl Visitor<'_> for IsAnyLetVisitor {
     fn visit_expr(&mut self, expr: &Expr<'_>) {
         if matches!(expr.kind, ExprKind::Let(..)) {
             self.0 = true;
+        } else {
+            walk_expr(self, expr);
         }
-
-        walk_expr(self, expr);
     }
 }