about summary refs log tree commit diff
diff options
context:
space:
mode:
authorStanislav Tkach <stanislav.tkach@gmail.com>2020-04-28 12:08:38 +0300
committerGitHub <noreply@github.com>2020-04-28 12:08:38 +0300
commit1afb6e6e3b23bd5555f34cc4dcd20349dfd789de (patch)
tree3b359532d789870a660cbe34e131e51c8cdc911c
parent2c4d5661137933dfe93c03b0f9e514d97bafdada (diff)
downloadrust-1afb6e6e3b23bd5555f34cc4dcd20349dfd789de.tar.gz
rust-1afb6e6e3b23bd5555f34cc4dcd20349dfd789de.zip
Extend example for the `unneeded_field_pattern` lint
Current example is incorrect (or pseudo-code) because a struct name is omitted. I have used the code from the tests instead. Perhaps this example can be made less verbose, but I think it is more convenient to see a "real" code as an example.
-rw-r--r--clippy_lints/src/misc_early.rs21
1 files changed, 19 insertions, 2 deletions
diff --git a/clippy_lints/src/misc_early.rs b/clippy_lints/src/misc_early.rs
index adfd8dfb1c1..62ee051624b 100644
--- a/clippy_lints/src/misc_early.rs
+++ b/clippy_lints/src/misc_early.rs
@@ -24,8 +24,25 @@ declare_clippy_lint! {
     /// **Known problems:** None.
     ///
     /// **Example:**
-    /// ```ignore
-    /// let { a: _, b: ref b, c: _ } = ..
+    /// ```rust
+    /// # struct Foo {
+    /// #     a: i32,
+    /// #     b: i32,
+    /// #     c: i32,
+    /// # }
+    /// let f = Foo { a: 0, b: 0, c: 0 };
+    ///
+    /// // Bad
+    /// match f {
+    ///     Foo { a: _, b: 0, .. } => {},
+    ///     Foo { a: _, b: _, c: _ } => {},
+    /// }
+    ///
+    /// // Good
+    /// match f {
+    ///     Foo { b: 0, .. } => {},
+    ///     Foo { .. } => {},
+    /// }
     /// ```
     pub UNNEEDED_FIELD_PATTERN,
     restriction,