about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbjorn3 <17426603+bjorn3@users.noreply.github.com>2025-02-07 14:47:21 +0000
committerbjorn3 <17426603+bjorn3@users.noreply.github.com>2025-02-07 16:02:19 +0000
commit21b60aad987f5e61658901675cd64a5736ee5eef (patch)
tree706597d8c012aa1ddd3df0b82acb4131218aa5a8
parentdb4b00f365d4cb2b02792ed88613443d18e721ac (diff)
downloadrust-21b60aad987f5e61658901675cd64a5736ee5eef.tar.gz
rust-21b60aad987f5e61658901675cd64a5736ee5eef.zip
Remove Linkage::Private
This is the same as Linkage::Internal except that it doesn't emit any
symbol. Some backends may not support it and it isn't all that useful
anyway.
-rw-r--r--src/base.rs2
-rw-r--r--src/mono_item.rs5
2 files changed, 1 insertions, 6 deletions
diff --git a/src/base.rs b/src/base.rs
index c9701fb9885..f2fc0980044 100644
--- a/src/base.rs
+++ b/src/base.rs
@@ -51,7 +51,6 @@ pub fn global_linkage_to_gcc(linkage: Linkage) -> GlobalKind {
         Linkage::WeakODR => unimplemented!(),
         Linkage::Appending => unimplemented!(),
         Linkage::Internal => GlobalKind::Internal,
-        Linkage::Private => GlobalKind::Internal,
         Linkage::ExternalWeak => GlobalKind::Imported, // TODO(antoyo): should be weak linkage.
         Linkage::Common => unimplemented!(),
     }
@@ -68,7 +67,6 @@ pub fn linkage_to_gcc(linkage: Linkage) -> FunctionType {
         Linkage::WeakODR => unimplemented!(),
         Linkage::Appending => unimplemented!(),
         Linkage::Internal => FunctionType::Internal,
-        Linkage::Private => FunctionType::Internal,
         Linkage::ExternalWeak => unimplemented!(),
         Linkage::Common => unimplemented!(),
     }
diff --git a/src/mono_item.rs b/src/mono_item.rs
index 239902df7f0..a2df7b2596f 100644
--- a/src/mono_item.rs
+++ b/src/mono_item.rs
@@ -61,10 +61,7 @@ impl<'gcc, 'tcx> PreDefineCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
         // compiler-rt, then we want to implicitly compile everything with hidden
         // visibility as we're going to link this object all over the place but
         // don't want the symbols to get exported.
-        if linkage != Linkage::Internal
-            && linkage != Linkage::Private
-            && self.tcx.is_compiler_builtins(LOCAL_CRATE)
-        {
+        if linkage != Linkage::Internal && self.tcx.is_compiler_builtins(LOCAL_CRATE) {
             #[cfg(feature = "master")]
             decl.add_attribute(FnAttribute::Visibility(gccjit::Visibility::Hidden));
         } else {