about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Howell <michael@notriddle.com>2023-05-22 16:41:52 -0700
committerMichael Howell <michael@notriddle.com>2023-05-22 16:46:29 -0700
commit24913bd768e3aa1bab4f0ba8a9310e965c17fae0 (patch)
tree6b26b44632fdffcb3ec83be427706bf4fcc58e43
parent5570fdae88cc93579cf2a03e9e2211051b0ef263 (diff)
downloadrust-24913bd768e3aa1bab4f0ba8a9310e965c17fae0.tar.gz
rust-24913bd768e3aa1bab4f0ba8a9310e965c17fae0.zip
rustdoc: remove unneeded `position: relative` setting CSS
This was added to control percentage sizes, in
79956b96e875e6ba2bfa551fabda6b7896f988ac

Now, the only percentage size is [`border-radius`], which is
based on the size of the box itself, not its containing block.
This leaves the property unused.

[`border-radius`]: https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius
-rw-r--r--src/librustdoc/html/static/css/settings.css1
-rw-r--r--tests/rustdoc-gui/settings.goml4
2 files changed, 2 insertions, 3 deletions
diff --git a/src/librustdoc/html/static/css/settings.css b/src/librustdoc/html/static/css/settings.css
index ff46ccee6c6..c1324c0760e 100644
--- a/src/librustdoc/html/static/css/settings.css
+++ b/src/librustdoc/html/static/css/settings.css
@@ -1,6 +1,5 @@
 .setting-line {
 	margin: 1.2em 0.6em;
-	position: relative;
 }
 
 .setting-radio input, .setting-check input {
diff --git a/tests/rustdoc-gui/settings.goml b/tests/rustdoc-gui/settings.goml
index bf1fe7be910..c37d969324c 100644
--- a/tests/rustdoc-gui/settings.goml
+++ b/tests/rustdoc-gui/settings.goml
@@ -301,7 +301,7 @@ wait-for-css: ("#help-button .popover", {"display": "block"})
 // Now we go to the settings page to check that the CSS is loaded as expected.
 go-to: "file://" + |DOC_PATH| + "/settings.html"
 wait-for: "#settings"
-assert-css: (".setting-line", {"position": "relative"})
+assert-css: (".setting-radio", {"cursor": "pointer"})
 
 assert-attribute-false: ("#settings", {"class": "popover"}, CONTAINS)
 compare-elements-position: (".sub form", "#settings", ("x"))
@@ -322,4 +322,4 @@ reload:
 set-window-size: (300, 1000)
 click: "#settings-menu"
 wait-for: "#settings"
-assert-css: (".setting-line", {"position": "relative"})
+assert-css: (".setting-radio", {"cursor": "pointer"})