about summary refs log tree commit diff
diff options
context:
space:
mode:
authorGuillaume Gomez <guillaume1.gomez@gmail.com>2025-01-07 15:30:26 +0100
committerGitHub <noreply@github.com>2025-01-07 15:30:26 +0100
commit2598d607b570dbb76ebdbb9bac5fd7708b6f9b60 (patch)
treed41e5d70be4d650dabf18e32f5818e9ff705b5a7
parenta33da79fa926fcce6fb30c515fcb968b649a38cc (diff)
parent614dc1c933c0fc4cf007715857f9951a39c72b86 (diff)
downloadrust-2598d607b570dbb76ebdbb9bac5fd7708b6f9b60.tar.gz
rust-2598d607b570dbb76ebdbb9bac5fd7708b6f9b60.zip
Rollup merge of #135187 - onur-ozkan:release-fix, r=pietroalbini
apply a workaround fix for the release roadblock

This has been a problem since the last two releases.

r? pietroalbini
-rw-r--r--src/build_helper/src/git.rs13
1 files changed, 12 insertions, 1 deletions
diff --git a/src/build_helper/src/git.rs b/src/build_helper/src/git.rs
index 2aad5650fa8..01bac1498c2 100644
--- a/src/build_helper/src/git.rs
+++ b/src/build_helper/src/git.rs
@@ -129,8 +129,19 @@ pub fn get_closest_merge_commit(
         git.current_dir(git_dir);
     }
 
+    let channel = include_str!("../../ci/channel");
+
     let merge_base = {
-        if CiEnv::is_ci() {
+        if CiEnv::is_ci() &&
+            // FIXME: When running on rust-lang managed CI and it's not a nightly build,
+            // `git_upstream_merge_base` fails with an error message similar to this:
+            // ```
+            //    called `Result::unwrap()` on an `Err` value: "command did not execute successfully:
+            //    cd \"/checkout\" && \"git\" \"merge-base\" \"origin/master\" \"HEAD\"\nexpected success, got: exit status: 1\n"
+            // ```
+            // Investigate and resolve this issue instead of skipping it like this.
+            (channel == "nightly" || !CiEnv::is_rust_lang_managed_ci_job())
+        {
             git_upstream_merge_base(config, git_dir).unwrap()
         } else {
             // For non-CI environments, ignore rust-lang/rust upstream as it usually gets