about summary refs log tree commit diff
diff options
context:
space:
mode:
author许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>2025-07-07 19:45:44 +0800
committerGitHub <noreply@github.com>2025-07-07 19:45:44 +0800
commit364dbd61f2b0928bb66d8c82626046cff11eae36 (patch)
tree33a620b443c3f290fe163f6cb8a452395133cc88
parent0938cb779f97b329a92256e0cca189c64701098a (diff)
parent979d7b2ca13eeecd2400fc9430088c39f8a17f53 (diff)
downloadrust-364dbd61f2b0928bb66d8c82626046cff11eae36.tar.gz
rust-364dbd61f2b0928bb66d8c82626046cff11eae36.zip
Rollup merge of #143577 - Noratrieb:Noratrieb-patch-4, r=Kobzol
Disable download-rustc for library profile

The feature currently completely breaks `x test` (rust-lang/rust#142505), core functionality of working on the standard library. Therefore it should be disabled by default until that problem is fixed. Having to wait a bit longer for a check build is nothing compared to completely mysterious build errors when testing.
-rw-r--r--src/bootstrap/defaults/bootstrap.library.toml3
-rw-r--r--src/bootstrap/src/utils/change_tracker.rs5
2 files changed, 7 insertions, 1 deletions
diff --git a/src/bootstrap/defaults/bootstrap.library.toml b/src/bootstrap/defaults/bootstrap.library.toml
index 24ff87191d6..3f811402b26 100644
--- a/src/bootstrap/defaults/bootstrap.library.toml
+++ b/src/bootstrap/defaults/bootstrap.library.toml
@@ -12,7 +12,8 @@ lto = "off"
 #
 # If compiler-affecting directories are not modified, use precompiled rustc to speed up
 # library development by skipping compiler builds.
-download-rustc = "if-unchanged"
+# FIXME: download-rustc is currently broken: https://github.com/rust-lang/rust/issues/142505
+download-rustc = false
 
 [llvm]
 # Will download LLVM from CI if available on your platform.
diff --git a/src/bootstrap/src/utils/change_tracker.rs b/src/bootstrap/src/utils/change_tracker.rs
index aa968ea3d98..424f211c7d4 100644
--- a/src/bootstrap/src/utils/change_tracker.rs
+++ b/src/bootstrap/src/utils/change_tracker.rs
@@ -456,4 +456,9 @@ pub const CONFIG_CHANGE_HISTORY: &[ChangeInfo] = &[
         severity: ChangeSeverity::Warning,
         summary: "The default check stage has been changed to 1. It is no longer possible to `x check` with stage 0. All check commands have to be on stage 1+. Bootstrap tools can now also only be checked for the host target.",
     },
+    ChangeInfo {
+        change_id: 143577,
+        severity: ChangeSeverity::Warning,
+        summary: "`download-rustc` has been temporarily disabled for the library profile due to implementation bugs (see #142505).",
+    },
 ];