diff options
| author | DevAccentor <dev.accentor@gmail.com> | 2022-06-05 10:26:29 +0200 |
|---|---|---|
| committer | DevAccentor <dev.accentor@gmail.com> | 2022-06-05 10:26:29 +0200 |
| commit | 3737abe802dc4c0f776634499bc666d6446a64c7 (patch) | |
| tree | f82d62c519ef270f8c10ff25df571d251fd3615e | |
| parent | 5a49918f36adc9fb176a9be59b6fc2afd46c3572 (diff) | |
| download | rust-3737abe802dc4c0f776634499bc666d6446a64c7.tar.gz rust-3737abe802dc4c0f776634499bc666d6446a64c7.zip | |
change based on review
| -rw-r--r-- | tests/ui/for_loops_over_fallibles.rs | 4 | ||||
| -rw-r--r-- | tests/ui/for_loops_over_fallibles.stderr | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/tests/ui/for_loops_over_fallibles.rs b/tests/ui/for_loops_over_fallibles.rs index bde78a9fd4a..3390111d0a8 100644 --- a/tests/ui/for_loops_over_fallibles.rs +++ b/tests/ui/for_loops_over_fallibles.rs @@ -21,12 +21,12 @@ fn for_loops_over_fallibles() { } // check over a `Result` - for x in result.into_iter() { + for x in result.iter_mut() { println!("{}", x); } // check over a `Result` - for x in result.iter_mut() { + for x in result.into_iter() { println!("{}", x); } diff --git a/tests/ui/for_loops_over_fallibles.stderr b/tests/ui/for_loops_over_fallibles.stderr index 635e08182d5..8c8c022243a 100644 --- a/tests/ui/for_loops_over_fallibles.stderr +++ b/tests/ui/for_loops_over_fallibles.stderr @@ -26,18 +26,18 @@ LL | for x in result { error: for loop over `result`, which is a `Result`. This is more readably written as an `if let` statement --> $DIR/for_loops_over_fallibles.rs:24:14 | -LL | for x in result.into_iter() { +LL | for x in result.iter_mut() { | ^^^^^^ | - = help: consider replacing `for x in result.into_iter()` with `if let Ok(x) = result` + = help: consider replacing `for x in result.iter_mut()` with `if let Ok(x) = result` error: for loop over `result`, which is a `Result`. This is more readably written as an `if let` statement --> $DIR/for_loops_over_fallibles.rs:29:14 | -LL | for x in result.iter_mut() { +LL | for x in result.into_iter() { | ^^^^^^ | - = help: consider replacing `for x in result.iter_mut()` with `if let Ok(x) = result` + = help: consider replacing `for x in result.into_iter()` with `if let Ok(x) = result` error: for loop over `option.ok_or("x not found")`, which is a `Result`. This is more readably written as an `if let` statement --> $DIR/for_loops_over_fallibles.rs:33:14 |
