about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAda Alakbarova <ada.alakbarova@proton.me>2025-08-21 23:35:49 +0200
committerAda Alakbarova <ada.alakbarova@proton.me>2025-08-22 15:03:15 +0200
commit3c3dc6da6fb49e7126fb84317dc2fb62bb869f19 (patch)
tree0c8a4ea87a5e80bbeba18f2cdef1ff90256fadf4
parentf0420110fedcbc5a34ec2ffeab6ef1238e171b88 (diff)
downloadrust-3c3dc6da6fb49e7126fb84317dc2fb62bb869f19.tar.gz
rust-3c3dc6da6fb49e7126fb84317dc2fb62bb869f19.zip
misc: don't bother checking the other branch
-rw-r--r--clippy_lints/src/useless_conversion.rs4
1 files changed, 1 insertions, 3 deletions
diff --git a/clippy_lints/src/useless_conversion.rs b/clippy_lints/src/useless_conversion.rs
index df0789db559..70ae982a445 100644
--- a/clippy_lints/src/useless_conversion.rs
+++ b/clippy_lints/src/useless_conversion.rs
@@ -407,9 +407,7 @@ impl<'tcx> LateLintPass<'tcx> for UselessConversion {
                             None,
                             hint,
                         );
-                    }
-
-                    if name == sym::from_fn && same_type_and_consts(a, b) {
+                    } else if name == sym::from_fn && same_type_and_consts(a, b) {
                         let mut app = Applicability::MachineApplicable;
                         let sugg = Sugg::hir_with_context(cx, arg, e.span.ctxt(), "<expr>", &mut app).maybe_paren();
                         let sugg_msg = format!("consider removing `{}()`", snippet(cx, path.span, "From::from"));