diff options
| author | beetrees <b@beetr.ee> | 2024-03-08 00:54:48 +0000 |
|---|---|---|
| committer | beetrees <b@beetr.ee> | 2024-03-08 00:54:48 +0000 |
| commit | 4bef0cca706d5284911d045e0c8ce86a8555fc6e (patch) | |
| tree | 6cb20db8a389580c685e4a25bc8c50d443c71ea6 | |
| parent | 9c3ad802d9b9633d60d3a74668eb1be819212d34 (diff) | |
| download | rust-4bef0cca706d5284911d045e0c8ce86a8555fc6e.tar.gz rust-4bef0cca706d5284911d045e0c8ce86a8555fc6e.zip | |
Fix misaligned loads when loading UEFI arg pointers
| -rw-r--r-- | compiler/rustc_codegen_ssa/src/base.rs | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/compiler/rustc_codegen_ssa/src/base.rs b/compiler/rustc_codegen_ssa/src/base.rs index 2161bf61daa..1a3c70cedd0 100644 --- a/compiler/rustc_codegen_ssa/src/base.rs +++ b/compiler/rustc_codegen_ssa/src/base.rs @@ -510,11 +510,13 @@ fn get_argc_argv<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>>( // Params for UEFI let param_handle = bx.get_param(0); let param_system_table = bx.get_param(1); + let ptr_size = bx.tcx().data_layout.pointer_size; + let ptr_align = bx.tcx().data_layout.pointer_align.abi; let arg_argc = bx.const_int(cx.type_isize(), 2); - let arg_argv = bx.alloca(cx.type_array(cx.type_ptr(), 2), Align::ONE); - bx.store(param_handle, arg_argv, Align::ONE); - let arg_argv_el1 = bx.gep(cx.type_ptr(), arg_argv, &[bx.const_int(cx.type_int(), 1)]); - bx.store(param_system_table, arg_argv_el1, Align::ONE); + let arg_argv = bx.alloca(cx.type_array(cx.type_ptr(), 2), ptr_align); + bx.store(param_handle, arg_argv, ptr_align); + let arg_argv_el1 = bx.inbounds_ptradd(arg_argv, bx.const_usize(ptr_size.bytes())); + bx.store(param_system_table, arg_argv_el1, ptr_align); (arg_argc, arg_argv) } else if cx.sess().target.main_needs_argc_argv { // Params from native `main()` used as args for rust start function |
