about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAlejandra González <blyxyas@gmail.com>2025-09-13 15:46:38 +0000
committerGitHub <noreply@github.com>2025-09-13 15:46:38 +0000
commit544e24a79fd5564d7abf84263e5f70fe06fa226d (patch)
treef37a2eca9c6df7b69daa7c6fb8551abbe959beca
parent0c87db244984556739e84a6c04f837eb418f84e1 (diff)
parent169eb87d6088d0c63884b9faa0287ee474a4101b (diff)
downloadrust-544e24a79fd5564d7abf84263e5f70fe06fa226d.tar.gz
rust-544e24a79fd5564d7abf84263e5f70fe06fa226d.zip
Remove expect `collapsible_span_lint_calls` and use `span_lint_and_help` (#15612)
Remove expected `collapsible_span_lint_calls` and use
`span_lint_and_help` since rust-lang/rust-clippy#7698 was resolved

changelog:none
-rw-r--r--clippy_lints/src/uninit_vec.rs11
1 files changed, 4 insertions, 7 deletions
diff --git a/clippy_lints/src/uninit_vec.rs b/clippy_lints/src/uninit_vec.rs
index cee4a53f03c..51116b5eba9 100644
--- a/clippy_lints/src/uninit_vec.rs
+++ b/clippy_lints/src/uninit_vec.rs
@@ -1,4 +1,4 @@
-use clippy_utils::diagnostics::{span_lint, span_lint_and_then};
+use clippy_utils::diagnostics::{span_lint, span_lint_and_help};
 use clippy_utils::higher::{VecInitKind, get_vec_init_kind};
 use clippy_utils::ty::{is_type_diagnostic_item, is_uninit_value_valid_for_ty};
 use clippy_utils::{SpanlessEq, is_integer_literal, is_lint_allowed, path_to_local_id, peel_hir_expr_while, sym};
@@ -95,16 +95,13 @@ fn handle_uninit_vec_pair<'tcx>(
 
             // Check T of Vec<T>
             if !is_uninit_value_valid_for_ty(cx, args.type_at(0)) {
-                // FIXME: #7698, false positive of the internal lints
-                #[expect(clippy::collapsible_span_lint_calls)]
-                span_lint_and_then(
+                span_lint_and_help(
                     cx,
                     UNINIT_VEC,
                     vec![call_span, maybe_init_or_reserve.span],
                     "calling `set_len()` immediately after reserving a buffer creates uninitialized values",
-                    |diag| {
-                        diag.help("initialize the buffer or wrap the content in `MaybeUninit`");
-                    },
+                    None,
+                    "initialize the buffer or wrap the content in `MaybeUninit`",
                 );
             }
         } else {