diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2025-03-12 13:45:48 +1100 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2025-03-17 08:20:56 +1100 |
| commit | 6698c26b3ab9ef90a31af1afc367bab3a359563c (patch) | |
| tree | 310698ee546a736a51d4833ea129098fbef9f694 | |
| parent | 8b87fefd76665236a304d3c0998e1021710ce1b0 (diff) | |
| download | rust-6698c26b3ab9ef90a31af1afc367bab3a359563c.tar.gz rust-6698c26b3ab9ef90a31af1afc367bab3a359563c.zip | |
Fix `is_relevant_impl`.
It determines if a function should have any `inline` attributes checked. For `ItemKind::Fn` it returns true or false depending on the details of the function; for anything other item kind it returns *true*. This latter case should instead be *false*. (In the nearby and similar functions `is_relevant_impl` and `is_relevant_trait` the non-function cases return false.) The effect of this is that non-functions are no longer checked. But rustc already disallows `inline` on any non-function items. So if anything its a tiny performance win, because that was useless anyway.
| -rw-r--r-- | src/tools/clippy/clippy_lints/src/attrs/utils.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/clippy/clippy_lints/src/attrs/utils.rs b/src/tools/clippy/clippy_lints/src/attrs/utils.rs index 0e650e49392..a5ce2137bff 100644 --- a/src/tools/clippy/clippy_lints/src/attrs/utils.rs +++ b/src/tools/clippy/clippy_lints/src/attrs/utils.rs @@ -24,7 +24,7 @@ pub(super) fn is_relevant_item(cx: &LateContext<'_>, item: &Item<'_>) -> bool { if let ItemKind::Fn { body: eid, .. } = item.kind { is_relevant_expr(cx, cx.tcx.typeck_body(eid), cx.tcx.hir_body(eid).value) } else { - true + false } } |
